Fix #9717: Correctly set null statistics of children of structs #9733
+56
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9717
When a struct field can have
NULL
values, the children of that struct field can also haveNULL
values transitively. In the linked query list extract setCAN_HAVE_NULL
of the child to true, but this did not get properly pushed into the stats of the children of the struct, leading to an incorrect optimization being made. This PR changes the statistics so thatSet(StatsInfo::CAN_HAVE_NULL_VALUES)
correctly propagates this information to the children of structs.