Skip to content

Conversation

StarveZhou
Copy link

Add support for collations during IN/NOT IN comparison.

This only solves part of Issue#604.

@github-actions github-actions bot marked this pull request as draft November 19, 2023 15:12
@StarveZhou StarveZhou marked this pull request as ready for review November 19, 2023 15:19
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good - one comment:

@github-actions github-actions bot marked this pull request as draft November 20, 2023 18:14
@StarveZhou StarveZhou marked this pull request as ready for review November 20, 2023 18:15
@StarveZhou
Copy link
Author

Anyone know why the CI (Windows Extensions (64-bit)) failed? I think my small PR is not related. :-(

@carlopi
Copy link
Contributor

carlopi commented Nov 20, 2023

Anyone know why the CI (Windows Extensions (64-bit)) failed? I think my small PR is not related. :-(

This is a problem related to a missing vcpkg resource, should be eventually solved by vpckg project.

@StarveZhou
Copy link
Author

Anyone know why the CI (Windows Extensions (64-bit)) failed? I think my small PR is not related. :-(

This is a problem related to a missing vcpkg resource, should be eventually solved by vpckg project.

So I can do nothing but wait now?

@github-actions github-actions bot marked this pull request as draft November 21, 2023 19:12
@StarveZhou StarveZhou marked this pull request as ready for review November 23, 2023 09:25
@github-actions github-actions bot marked this pull request as draft November 25, 2023 07:57
@StarveZhou StarveZhou marked this pull request as ready for review November 25, 2023 12:26
@StarveZhou
Copy link
Author

@Mytherin Hi mark! Are there any issues for this MR? Hope to hear suggests from you. :-)

@Mytherin Mytherin merged commit 293902e into duckdb:main Nov 29, 2023
@Mytherin
Copy link
Collaborator

Thanks! LGTM

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants