-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Issue#604 Support collations during IN/NOT IN operations. #9724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c147fb6
to
aae4c58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good - one comment:
aae4c58
to
d6394c7
Compare
Anyone know why the CI (Windows Extensions (64-bit)) failed? I think my small PR is not related. :-( |
This is a problem related to a missing vcpkg resource, should be eventually solved by vpckg project. |
So I can do nothing but wait now? |
d6394c7
to
bfd3a55
Compare
bfd3a55
to
2e03be6
Compare
2e03be6
to
2bf12ec
Compare
@Mytherin Hi mark! Are there any issues for this MR? Hope to hear suggests from you. :-) |
Thanks! LGTM |
Merge pull request duckdb/duckdb#9724 from StarveZhou/issue_604
Add support for collations during IN/NOT IN comparison.
This only solves part of Issue#604.