[Python] Fix lossy datetime.timedelta to INTERVAL conversion
#9688
+94
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or, they should be identical. Also check that SQL INTERVAL constants are equal to the identical datetime.timedelta variant
|
Thanks! LGTM |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 11, 2023
Merge pull request duckdb/duckdb#9688 from Tishj/python_fix_timedelta_conversion Merge pull request duckdb/duckdb#9693 from szarnyasg/update-issue-template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9431
What we used to do was convert days to months by dividing with a constant.
This constant is lossy however, and should not be used in this way.
The issue shows the result of this.
What we do now is create separate INTERVAL values from the components of the timedelta and use the existing addition mechanism to add these together to form the result.