Skip to content

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Nov 13, 2023

When not synchronised, multi-threaded interactions with a statement could cause the query result to segfault, since it could be destroyed while still in use.

Fix #9528

@pdet pdet changed the title [JDBC} Sync all methods from a statement that interact with a query result [JDBC] Sync all methods from a statement that interact with a query result Nov 13, 2023
@pdet
Copy link
Contributor Author

pdet commented Nov 13, 2023

Edit: this is actually reproducible outside of adding Arrow as a dependency, I'm adding a test for it.

@github-actions github-actions bot marked this pull request as draft November 14, 2023 13:15
@pdet pdet marked this pull request as ready for review November 14, 2023 18:28
@Mytherin Mytherin changed the base branch from feature to main November 20, 2023 12:41
@Mytherin
Copy link
Collaborator

@Mause any thoughts on adding synchronized to these methods? Do you think this is the correct solution here?

@Mytherin Mytherin merged commit 0e01450 into duckdb:main Nov 24, 2023
@Mause
Copy link
Member

Mause commented Nov 24, 2023

@Mause any thoughts on adding synchronized to these methods? Do you think this is the correct solution here?

Seems reasonable yeah

(Sorry for not replying earlier, currently on holiday)

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 14, 2023
Merge pull request duckdb/duckdb#9736 from carlopi/format_bytes
Merge pull request duckdb/duckdb#9659 from pdet/arrow_jdbc_segfault
@pdet pdet deleted the arrow_jdbc_segfault branch June 27, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JVM SIGSEGV after connection close with ingested arrow data.
3 participants