Skip to content

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Oct 31, 2023

This PR adds two new functions to the Progress API. It also fixes some variable shadowing warnings.

  1. TotalCardinality() -> Returns the total cardinality of all scanners in a query.
  2. CurrentRowsRead() -> Returns how many rows the scanners have pushed.

cc: @cpcloud

@github-actions github-actions bot marked this pull request as draft November 1, 2023 13:42
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM - one comment:

@Mytherin Mytherin marked this pull request as ready for review November 13, 2023 15:30
@Mytherin Mytherin changed the base branch from feature to main November 20, 2023 12:43
@github-actions github-actions bot marked this pull request as draft November 28, 2023 23:13
@pdet pdet marked this pull request as ready for review November 28, 2023 23:19
@github-actions github-actions bot marked this pull request as draft November 29, 2023 10:23
@pdet pdet marked this pull request as ready for review November 29, 2023 10:26
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mytherin Mytherin merged commit 9c91b3a into duckdb:main Nov 29, 2023
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 14, 2023
Merge pull request duckdb/duckdb#9531 from pdet/expose_progress_card
@pdet pdet deleted the expose_progress_card branch June 27, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants