-
Notifications
You must be signed in to change notification settings - Fork 2.6k
5614 database invalidated #9513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refs. but replacing text with column0 passes. Needs to be fixed
… But then the proper datasource scan is added later (but I dont now where). Need to figure that out
…th of 0, and throw any correlated bind error results
Mytherin
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Great that you got this fixed - just one minor comment:
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 11, 2023
Merge pull request duckdb/duckdb#9392 from lnkuiper/parquet_encryption Merge pull request duckdb/duckdb#9461 from hawkfish/merge-sort-trees Merge pull request duckdb/duckdb#8788 from alnkesq/capi_create_enum_type Merge pull request duckdb/duckdb#9513 from Tmonster/5614-database-invalidated Merge pull request duckdb/duckdb#9622 from Mytherin/typescoping Merge pull request duckdb/duckdb#9615 from hawkfish/strptime-infinity Merge pull request duckdb/duckdb#9627 from Mytherin/attachifnotexists Merge pull request duckdb/duckdb#9648 from samansmink/add-keep-alive-toggle Merge pull request duckdb/duckdb#9638 from taniabogatsch/bench-refactor Merge pull request duckdb/duckdb#9651 from Mytherin/getenv
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5614
This was a tough one.
When the where binder attempted to bind the 'text' alias in the where clause, the column_alias_binder would bind it with a depth of 0 (something I added a long time ago). This was incorrect. We should be binding c0 with the correct depth count.
When it has a depth of 0, it is not planned as a correlated subquery. With a depth of 1 it is, this will fix the issue, but it would break some other correlated subquery tests. Specifically tests with a having clause.
Thankfully, the tests were only broken in such a way that the error was incorrect. After looking at the code, I decided to propagate up correlated subquery binding errors instead of stalling them. The previous flow was the following
The new flow will return error Y (or the last seen error from correlatedSubquery binding).
This has the benefit of fixing some lateral join errors that were a bit cryptic