Removed artificial `HUGEINT` minimum #9441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mytherin merged 31 commits into duckdb:feature from nickgerrets:uuid_compression_bug

Nov 8, 2023

Contributor

nickgerrets commented Oct 23, 2023

Solves #9193

For legacy reasons an artificial minimum limit was placed on the HUGEINT type. This is causing issues with integer wrapping and intoduced a bug when compressing UUID's. This PR removes this limit.

The minimum goes from:
-170141183460469231731687303715884105727
To:
-170141183460469231731687303715884105728

nickgerrets added 9 commits

October 9, 2023 16:04


          removing custom limit on hugeint minimum

27ae8f2


          removed hugeint lower limit test

05fc311


          overflow tests

08f689e


          corrected tests

920c045


          Merge branch 'main' into uuid_compression_bug

4894dbd


          corrected minimum UUID

9dcaa28


          updated storage version

aba7b62


          corrected tests

383fe0a


          corrected minimum hugeint value

4035bb0

Tishj reviewed

View reviewed changes

test/sql/types/hugeint/test_hugeint_arithmetic.test Show resolved Hide resolved

Tishj reviewed

View reviewed changes

test/sql/types/hugeint/test_hugeint_arithmetic.test Show resolved Hide resolved

Tishj reviewed

View reviewed changes

src/storage/storage_info.cpp Outdated Show resolved Hide resolved

Tishj reviewed

View reviewed changes

src/common/types/hugeint.cpp Show resolved Hide resolved

Tishj reviewed

View reviewed changes

src/common/types/hugeint.cpp Outdated Show resolved Hide resolved

Tishj reviewed

View reviewed changes

src/common/types/hugeint.cpp Outdated Show resolved Hide resolved

Tishj reviewed

View reviewed changes

src/include/duckdb/common/types/cast_helpers.hpp Outdated Show resolved Hide resolved

Tishj reviewed

View reviewed changes

src/include/duckdb/common/types/cast_helpers.hpp Outdated Show resolved Hide resolved

szarnyasg added a commit to szarnyasg/duckdb-web that referenced this pull request


          Change HUGEINT's minimum value

667e204

See duckdb/duckdb#9441

szarnyasg mentioned this pull request

Change HUGEINT's minimum value duckdb/duckdb-web#1431

Merged


          reverted storage version change

fb4ee40

github-actions bot marked this pull request as draft

October 23, 2023 11:25

nickgerrets added 8 commits

October 23, 2023 13:44


          explicit error message

966242a


          assertion

1956ea1


          fixed division

4cd3fb2


          removed unnecessary comments

d50b07b


          removed unnecessary Finalize

12b5638


          removed dead code

4833b7b


          formatting

f7779bc


          regenerate storage version

166fb5f

szarnyasg added the Needs Documentation label

szarnyasg added Needs Documentation and removed Needs Documentation labels

Tishj self-assigned this

szarnyasg mentioned this pull request

[duckdb/#9441] - Removed artificial HUGEINT minimum needs documentation duckdb/duckdb-web#1449

Closed

Tishj approved these changes

View reviewed changes

Contributor

Tishj left a comment •

edited

Loading

Thanks, looks good to me now 👍

nickgerrets added 4 commits

October 30, 2023 14:13


          correctly clearnly divisible check

a15fb1f


          added test for "cleanly divisible" check

2bf980e


          corrected test

4eb173b


          additional modulo test

51fe57c

github-actions bot marked this pull request as draft

October 30, 2023 13:43


          formatting

673c563

nickgerrets marked this pull request as ready for review

October 30, 2023 14:31

Mytherin approved these changes

View reviewed changes

Collaborator

Mytherin left a comment

Thanks for the PR! LGTM - one minor comment

src/include/duckdb/common/types/cast_helpers.hpp Outdated Show resolved Hide resolved


          changed condition to assertion

d3241fc

github-actions bot marked this pull request as draft

November 6, 2023 09:50

nickgerrets marked this pull request as ready for review

November 6, 2023 09:51


          Merge branch 'main' into uuid_compression_bug

cce061d

github-actions bot marked this pull request as draft

November 6, 2023 13:10

nickgerrets marked this pull request as ready for review

November 6, 2023 13:10

lnkuiper and others added 3 commits

November 6, 2023 22:54


          wrong variable

21e04ed


          Merge pull request duckdb#9587 from lnkuiper/typo

Fix typo


          Merge branch 'main' into uuid_compression_bug

565f3d3

github-actions bot marked this pull request as draft

November 7, 2023 10:56

nickgerrets marked this pull request as ready for review

November 7, 2023 10:57

Mytherin changed the base branch from main to feature

November 8, 2023 13:11

Mytherin merged commit 96be357 into duckdb:feature

Collaborator

Mytherin commented Nov 8, 2023

Thanks!

nickgerrets deleted the uuid_compression_bug branch

November 8, 2023 13:31

nickgerrets mentioned this pull request

Inserting many identical UUIDs triggers underflow in HUGEINT addition #9193

Closed

1 task

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request


          chore: Update vendored sources to duckdb/duckdb@96be357

d5756a8

Merge pull request duckdb/duckdb#9441 from nickgerrets/uuid_compression_bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Documentation