fix for System.Data.ODBC GetSchema() #9336
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiadegraaf
approved these changes
Oct 13, 2023
OK it looks like I managed to please the format CI... Is there a way to do that in Windows? I guess I could have pulled python commands from makefile. Since I'm on a Mac and I had a venv with most of the prerequisites and make I ran from there...and changed the line endings of all the files...ouch. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Data.ODBC GetSchema() includes
SYSTEM TABLEwhen building the query for SqlTables() method. This table doesn't exist in DuckDB and so it breaks the query. This fix addswhich removes
SYSTEM TABLEif it is found in the query.Along with helpful changes by @maiadegraaf this will solve #6321.