Skip to content

Conversation

Mytherin
Copy link
Collaborator

@Mytherin Mytherin commented Oct 5, 2023

No description provided.

@github-actions github-actions bot marked this pull request as draft October 6, 2023 07:14
@Mytherin Mytherin marked this pull request as ready for review October 6, 2023 08:37
@github-actions github-actions bot marked this pull request as draft November 24, 2023 11:56
@Mytherin Mytherin marked this pull request as ready for review November 24, 2023 12:30
@carlopi
Copy link
Contributor

carlopi commented Nov 24, 2023

Note to self: patches should be probably NOT merged for a bit in the extensions, and just live with them around. Reason is that once the patches land in [sqlite|postgres]_scanner, they will not be compatible anymore with v0.9.2 (at least, not without patches!).

@Mytherin
Copy link
Collaborator Author

Makes sense. I think this also breaks the MySQL extension actually but since that isn't defined as part of the out_of_tree_extensions here I can't patch it. On the flip side that also means it doesn't break the CI - so we can just resolve it at a later stage.

@github-actions github-actions bot marked this pull request as draft November 24, 2023 16:12
@Mytherin Mytherin marked this pull request as ready for review November 24, 2023 16:14
@Mytherin Mytherin merged commit f5c6de7 into duckdb:main Nov 25, 2023
@Mytherin Mytherin deleted the transactioncleanup branch December 4, 2023 11:44
krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 14, 2023
Merge pull request duckdb/duckdb#9237 from Mytherin/transactioncleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants