Skip to content

[Dev] Fix CI failure caused by #7113 #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2023
Merged

[Dev] Fix CI failure caused by #7113 #8533

merged 1 commit into from
Aug 11, 2023

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Aug 10, 2023 •
edited
Loading

GCC4.8 seems to not be happy about us wanting to implicitly construct a std::pair<string, BoundValueParameter> from a std::pair<string, Value> even though this constructor exists:

	explicit BoundParameterData(Value val) : value(std::move(val)), return_type(value.type()) {
	}

We now explicitly construct the pair, hopefully making GCC4.8 happy

This was the (seemingly innocuous) diff:

-		for (idx_t i = 0; i < bind_values.size(); i++) {
-			prepared_planner.parameter_data.emplace_back(bind_values[i]);
+		for (auto &pair : bind_values) {
+			prepared_planner.parameter_data.emplace(pair);

(they used to be vectors, and are now maps)

@hannes hannes merged commit 5cf634e into duckdb:master Aug 11, 2023
carlopi added a commit to carlopi/duckdb that referenced this pull request Aug 14, 2023
@carlopi
Fix gcc weird behaviour around template deduction (duckdb#8533)
5d650a1
carlopi added a commit to carlopi/duckdb that referenced this pull request Aug 15, 2023
@carlopi
Fix gcc weird behaviour around template deduction (duckdb#8533)
d2eb22e
carlopi added a commit to carlopi/duckdb that referenced this pull request Aug 15, 2023
@carlopi
Fix gcc weird behaviour around template deduction (duckdb#8533)
20ecec6
@carlopi carlopi mentioned this pull request Aug 15, 2023
Merged
hannes added a commit that referenced this pull request Aug 16, 2023
@hannes
Merge pull request #8576 from carlopi/fix_gcc
ca1301a 
Fix gcc weird behaviour around template deduction (#8533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tishj @hannes