Skip to content

Fix broken CI because of RESET statement #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2022
Merged

Fix broken CI because of RESET statement #5671

merged 2 commits into from
Dec 13, 2022
+6 −0

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Dec 12, 2022 •
edited
Loading

This PR should fix the broken CI

closes #5666
Sorry @Maxxen but I feel responsible for this, and I'd like this to be fixed tomorrow morning

Verified this compiles + passes all the .test unittests on reldebug

@Tishj
Copy link
Contributor Author

Tishj commented Dec 12, 2022

Are the regressions tests failing because the compilation of the current master is failing, so it can't compile+run it to generate the comparison?

@Mause Mause mentioned this pull request Dec 13, 2022
Merged
@Mytherin Mytherin merged commit dc7639c into duckdb:master Dec 13, 2022
@Mytherin
Copy link
Collaborator

Thanks!

@Mytherin
Copy link
Collaborator

Are the regressions tests failing because the compilation of the current master is failing, so it can't compile+run it to generate the comparison?

Yes, indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tishj @Mytherin @Maxxen