Skip to content

Conversation

Maxxen
Copy link
Member

@Maxxen Maxxen commented Dec 12, 2022

This somehow slipped through to master.

Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Tishj
Copy link
Contributor

Tishj commented Dec 12, 2022

Ah yea I know why this fails, I added a test for RESET in test_reset.cpp, this new option is missing from that test

@Tishj
Copy link
Contributor

Tishj commented Dec 12, 2022

I'm gonna make a PR to fix this, hopefully we can merge it first thing in the morning 👍
sorry @Maxxen I also thought this was the only change needed but I forgot about this test I added 😅

@Maxxen
Copy link
Member Author

Maxxen commented Dec 13, 2022

argh, nerd-sniped again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants