Skip to content

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented May 30, 2025

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit tests

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Confirm changes work for use case that discovered this limitation

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

The output file names of 1 use case have changed to format the forecast lead months from e.g. F3m to F03. This is an improvement.

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by 6/4/2025.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…te tags. Added tests to ensure correct behavior occurs. Rename format_hms function to be more clear of what it actually does now
@georgemccabe georgemccabe added this to the METplus-6.2.0 milestone May 30, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.2 Development May 30, 2025
@georgemccabe georgemccabe linked an issue May 30, 2025 that may be closed by this pull request
24 tasks
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.2 Development May 30, 2025
@georgemccabe georgemccabe requested a review from j-opatz June 2, 2025 15:09
@georgemccabe georgemccabe marked this pull request as ready for review June 2, 2025 15:09
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on the use case that found the monthly lead template format that this branch produces output as expected: instead of "1m", lead requests now produce "01". The leading 0 is consistent with other forms of time in METplus and is easily removed in Python scripting.
Also confirmed that the differences in the s2s use case are strictly in name only; the contents of the files do not change. And as noted, these changes are for the better.

@georgemccabe georgemccabe merged commit 59da685 into develop Jun 3, 2025
80 of 82 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.2 Development Jun 3, 2025
@georgemccabe georgemccabe deleted the feature_3008_lead_months branch June 3, 2025 16:41
georgemccabe pushed a commit that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Enhancement: Support months and years in lead filename template tags
2 participants