Skip to content

Feature #2962 RMWAnalysis wrapper #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 22, 2025
Merged

Feature #2962 RMWAnalysis wrapper #2985

merged 10 commits into from
May 22, 2025

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented May 20, 2025 •
edited
Loading

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit tests and basic use case

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

New output from new use case will require update of truth data

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 5/21/2025.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1 Development May 20, 2025
@georgemccabe georgemccabe added this to the METplus-6.1.0 milestone May 20, 2025
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.1 Development May 20, 2025
@georgemccabe georgemccabe linked an issue May 20, 2025 that may be closed by this pull request
New Wrapper: RMW-Analysis #2962
Closed
24 tasks
@georgemccabe georgemccabe marked this pull request as ready for review May 20, 2025 21:25
@JohnHalleyGotway
Copy link
Collaborator

@mkavulich I see that you're back in the office on Wed, May 21st. Can you please test the code for this PR tomorrow? And if you're not able to, please let me know, and I can review instead.

FYI, I checked out this feature branch in seneca:/d1/projects/METplus/pull_requests/METplus-6.1.0/pr_2985/METplus as the met_test user. Just let me know if you have any issues running METplus from there.

@georgemccabe georgemccabe mentioned this pull request May 21, 2025
Merged
16 tasks
@georgemccabe georgemccabe requested review from JohnHalleyGotway and removed request for mkavulich May 22, 2025 14:52
@JohnHalleyGotway JohnHalleyGotway mentioned this pull request May 22, 2025
Closed
22 tasks
JohnHalleyGotway
JohnHalleyGotway approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

@georgemccabe as we already discussed over Slack, while reviewing this PR I found some short-comings in the RMW-Analysis tool itself, as documented in dtcenter/MET#3168. I'm proposing that we fix its functionality in the MET-12.2.0 release, if not sooner.

And thanks for updating the parsing logic for model, storm_id, storm_name, basin, and cyclone from strings to arrays of strings. I'll correct the MET documentation for dtcenter/MET#3168 as well.

I tested the RMW-Analysis wrapper with the seneca:/d1/projects/METplus/pull_requests/METplus-6.1.0/pr_2985/run_test.sh script and confirmed that setting METplus config options produced the expected environment variables, referenced by the wrapped RMW-Analysis config file.

@georgemccabe georgemccabe merged commit cff65eb into develop May 22, 2025
83 of 85 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.1 Development May 22, 2025
@georgemccabe georgemccabe deleted the feature_2962_rmw_analysis branch May 22, 2025 22:29
metplus-bot added a commit that referenced this pull request May 22, 2025
@metplus-bot
added entry to update truth change log: develop #2985 and #2987
4d5f901
@github-actions github-actions bot mentioned this pull request May 22, 2025
Merged
georgemccabe pushed a commit that referenced this pull request May 22, 2025
@github-actions
Update develop-ref after #2985 and #2987 (#2990)
05f85db
metplus-bot added a commit that referenced this pull request May 23, 2025
@metplus-bot
added entry to update truth change log: develop #2985 and #2987 - att…
ca6c32e 
…empt 2
@github-actions github-actions bot mentioned this pull request May 23, 2025
Merged
georgemccabe pushed a commit that referenced this pull request May 23, 2025
@github-actions
Update develop-ref after #2985 and #2987 - attempt 2 (#2992)
e4253c9
metplus-bot added a commit that referenced this pull request May 23, 2025
@metplus-bot
added entry to update truth change log: develop #2985 and #2987 - att…
80da069 
…empt 3
@github-actions github-actions bot mentioned this pull request May 23, 2025
Merged
georgemccabe pushed a commit that referenced this pull request May 23, 2025
@github-actions
Update develop-ref after #2985 and #2987 - attempt 3 (#2993)
780f0f3
metplus-bot added a commit that referenced this pull request May 23, 2025
@metplus-bot
added entry to update truth change log: develop #2985 and #2987 - att…
9429b0a 
…empt 4
@github-actions github-actions bot mentioned this pull request May 23, 2025
Merged
georgemccabe pushed a commit that referenced this pull request May 23, 2025
@github-actions
Update develop-ref after #2985 and #2987 - attempt 4 (#2994)
91d3847
metplus-bot added a commit that referenced this pull request Jun 11, 2025
@metplus-bot
added entry to update truth change log: develop #2985
3dd531e
@github-actions github-actions bot mentioned this pull request Jun 11, 2025
Merged
georgemccabe pushed a commit that referenced this pull request Jun 11, 2025
@github-actions
Update develop-ref after #2985 (#3018)
8e12df2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnHalleyGotway JohnHalleyGotway JohnHalleyGotway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
METplus-6.1 Development
Status: 🏁 Done
Milestone
METplus-6.1.0
Development

Successfully merging this pull request may close these issues.

New Wrapper: RMW-Analysis
2 participants
@georgemccabe @JohnHalleyGotway