Skip to content

Conversation

reza-armuei
Copy link
Contributor

@reza-armuei reza-armuei commented Oct 10, 2023

I think if condition at line 78 in py_embed_ingest wrapper cannot be reached as ingest_script_addons wont be an empty list. So it was not covered in the test and I would suggest to remove this line.

Pull Request Testing

  • Describe testing already performed for these changes:

    I ran pytest locally and everything passed.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    Yes

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    Yes

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: @georgemccabe
    Select: METplus-Wrappers-6.0.0 Development
    Select: METplus-6.0.0
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the wrapper code and agree that the if-condition will never be met and can be removed. A check to see if no indices were found to report an error would be useful and testable. I will make those changes and update the tests accordingly. Thank you for bringing this to my attention.

These tests look good. Thank you for adding them, @reza-armuei!

@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone Oct 18, 2023
@georgemccabe georgemccabe linked an issue Oct 18, 2023 that may be closed by this pull request
17 tasks
@georgemccabe georgemccabe merged commit 4e42ab4 into dtcenter:develop Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Improve METplus test coverage
2 participants