Skip to content

Bugfix: Fix reset of arguments for some wrappers (i.e. GenEnsProd) after each run #1555

@georgemccabe

Description

@georgemccabe

Describe the Problem

If more than 1 forecast lead is specified with LEAD_SEQ, then the GenEnsProd wrapper does not properly reset the arguments. This results in the first file list file being used for all subsequent runs and multiple -config or -ctrl arguments being added to each subsequent command.

Expected Behavior

Commands generated should set the correct file for the -ens input and only add the -config/-ctrl arguments once.

Environment

Describe your runtime environment: Any

To Reproduce

Describe the steps to reproduce the behavior:

  1. Copy the parm/use_cases/met_tool_wrapper/GenEnsProd/GenEnsProd.conf file
  2. Change the value for LEAD_SEQ to "24H, 48H"
    LEAD_SEQ = 24H, 48H
  3. Run the use case with DO_NOT_RUN_EXE=True and INPUT_MUST_EXIST=False so the commands will run even if the input data is not available.
    run_metplus.py GenEnsProd.conf config.INPUT_MUST_EXIST=False config.DO_NOT_RUN_EXE=True
  4. Confirm the same file list is used for every run and duplicate -config and -ctrl arguments appear in the 2nd command generated.

Relevant Deadlines

Cut METplus 4.1.1 bugfix release with MET 10.1.1 bugfix release (this or next week?)

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions