bugfix 1555 main_v4.1 clear args properly #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
…l to run_at_time_once function so that all wrappers that inherit from RuntimeFreq will be cleared properly before running, not just GenEnsProd
…ue in TC_GEN_CUSTOM_LOOP_LIST and made the fix to get the test to pass
… redundant calls when using custom loop list
…stom loop list is used
JohnHalleyGotway
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
I approve of these changes.
All GHA tests passed with no differences flagged.
I reviewed the changes to 20 files:
- 12 new empty files added to test multiple lead times.
- updates to tests for the gen_ens_prod, tc_gen, and user_script wrappers.
- adding calls to clear in tc_gen and tcrmw wrappers.
- update met_util to pass custom info and reference in the runtime freq wrapper.
I don't completely understand all the details, but I don't see any obvious problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per#1555, add call to clear function to reset arguments between each forecast lead run
NOTE: Issue #1555 should not be closed because changes are needed for the develop branch as well. Merging this PR will likely automatically close the issue but it should be reopened.
Pull Request Testing
Ensure all automated tests pass. The code change is minimal but I updated the unit tests and added more empty files used for testing. We already confirmed the change fixes the issue on Cheyenne, but if you'd like you can test using the example from #1555 using the 4.1.0 release and the bugfix branch.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
Python unit tests were updated but they should all pass as before.
Please complete this pull request review by MET 10.1.1 bugfix release.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes