Skip to content

fix wrong usage of bool_from_envvar #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2022
Merged

fix wrong usage of bool_from_envvar #997

merged 2 commits into from
Aug 27, 2022

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Aug 20, 2022 •
edited
Loading

fixes #996

@Emilgardis Emilgardis requested a review from a team as a code owner August 20, 2022 16:47
@Emilgardis
Copy link
Member Author

bors r+

@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Aug 20, 2022
bors bot added a commit that referenced this pull request Aug 20, 2022
@bors @Emilgardis
Merge #997
7a82fcf 
997: fix wrong usage of bool_from_envvar r=Emilgardis a=Emilgardis

fixes #996 

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@ChriFo ChriFo mentioned this pull request Aug 20, 2022
Closed
11 tasks
@bors
Copy link
Contributor

bors bot commented Aug 20, 2022

Build failed:

@Emilgardis
Copy link
Member Author

haven't tried this, but assuming it'll fix it

bors try --target dragonfly

bors bot added a commit that referenced this pull request Aug 20, 2022
@bors
Try #997: --target dragonfly
9503370
@bors
Copy link
Contributor

bors bot commented Aug 20, 2022

try

Build succeeded:

@Emilgardis
Copy link
Member Author

does the kvm inclusion need a changelog mention? I think it's fine

@Emilgardis Emilgardis mentioned this pull request Aug 26, 2022
Merged
@Alexhuszagh
Copy link
Contributor

does the kvm inclusion need a changelog mention? I think it's fine

I don't think so, lgtm

@Alexhuszagh
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 27, 2022

Build succeeded:

@bors bors bot merged commit 3d03f75 into cross-rs:main Aug 27, 2022
@Emilgardis Emilgardis deleted the fix/issue996 branch August 27, 2022 14:25
@Emilgardis Emilgardis mentioned this pull request Sep 29, 2022
Merged
@Emilgardis Emilgardis mentioned this pull request Feb 4, 2023
Merged
bors bot added a commit that referenced this pull request Feb 4, 2023
@bors @Emilgardis
@Alexhuszagh @taiki-e
Merge #1201
bfc6edc 
1201: Release v0.2.5 r=Emilgardis a=Emilgardis

See #962 (comment)

includes

ee3c972 #962
fc3df66 #1166
33ee940 in #997
81c1e59 #950
6a57d01 #1183

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot added a commit that referenced this pull request Feb 4, 2023
@bors @Emilgardis
@Alexhuszagh @taiki-e
Merge #1201
570936d 
1201: Release v0.2.5 r=Emilgardis a=Emilgardis

See #962 (comment)

includes

ee3c972 #962
fc3df66 #1166
33ee940 in #997
81c1e59 #950
6a57d01 #1183

Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
@Emilgardis Emilgardis added this to the v0.2.5 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexhuszagh Alexhuszagh Alexhuszagh approved these changes

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
v0.2.5
Development

Successfully merging this pull request may close these issues.

Unable to build with flag --quiet.
2 participants
@Emilgardis @Alexhuszagh