don't spin on CARGO=cross
#865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like this approach, but it simulates what we did in 0.2.1 before #808, only difference is that there's some indirection happening |
Alexhuszagh
reviewed
Jun 26, 2022
| @@ -1,6 +1,17 @@ | |||
| #![deny(missing_debug_implementations, rust_2018_idioms)] | |||
|
|
|||
| pub fn main() -> cross::Result<()> { | |||
| if std::env::var(cross::IN_CROSS_CONTEXT_ENV).is_ok() { | |||
There was a problem hiding this comment.
I don't think this is the correct approach.
Alexhuszagh
added a commit
to Alexhuszagh/cross
that referenced
this pull request
Jun 26, 2022
Provides behavior consistent with `cargo` itself, which also ignores it. Closes cross-rs#864. Supersedes cross-rs#865. Partially reverts cross-rs#808.
|
Closed since we approved #868. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #864