Skip to content

add issue templates #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2022
Merged

add issue templates #735

merged 4 commits into from
May 31, 2022

Conversation

Emilgardis
Copy link
Member

resolves #732

@Emilgardis Emilgardis requested a review from a team as a code owner May 31, 2022 21:43
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label May 31, 2022
@Alexhuszagh
Copy link
Contributor

Any reason for not using Markdown for the issue templates? It can be a fair amount more readable. An example would be:

---
name: Bug report
about: Create a report to help us improve.
title: "[BUG]"
labels: bug
---

## Description

Please include a clear and concise description of the bug.

## Prerequisites

Here are a few things you should provide to help me understand the issue:

- Rust version: `rustc -V`
- cross version:
- cross targets used:

## Test case

Please provide a short, complete example of the issue.

## Additional Context
Add any other context about the problem here.

@Emilgardis
Copy link
Member Author

@Emilgardis
Copy link
Member Author

Any reason for not using Markdown for the issue templates?

Wanted to try out the beta feature for forms :D I think I like it

@Emilgardis
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request May 31, 2022
734: Fix ARMv6 HF image to correctly build for ARMv6 architecture. r=Emilgardis a=Alexhuszagh

Change the `arm-unknown-linux-gnueabihf` to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7.

This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running `crosstool-ng/configure.sh`, which scans that directory for all `*.config.in` files, and configures them to `docker/crosstool-config`. The script can have the toolchain versions modified via `GCC_VERSION`, `GLIBC_VERSION`, and `LINUX_VERSION`.

Closes #426.

735: add issue templates r=Emilgardis a=Emilgardis

resolves #732


Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 31, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@Emilgardis
Copy link
Member Author

bors cancel

@bors
Copy link
Contributor

bors bot commented May 31, 2022

Canceled.

@Emilgardis
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request May 31, 2022
734: Fix ARMv6 HF image to correctly build for ARMv6 architecture. r=Emilgardis a=Alexhuszagh

Change the `arm-unknown-linux-gnueabihf` to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7.

This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running `crosstool-ng/configure.sh`, which scans that directory for all `*.config.in` files, and configures them to `docker/crosstool-config`. The script can have the toolchain versions modified via `GCC_VERSION`, `GLIBC_VERSION`, and `LINUX_VERSION`.

Closes #426.

735: add issue templates r=Emilgardis a=Emilgardis

resolves #732


Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 31, 2022

Canceled.

@Emilgardis
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 31, 2022

Build succeeded:

@bors bors bot merged commit 5f4770f into main May 31, 2022
@bors bors bot deleted the issue-templates branch May 31, 2022 23:32
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup issue templates
2 participants