Skip to content

Disable Recursive Read-only (RRO) mounts feature #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

Disable Recursive Read-only (RRO) mounts feature #7828

merged 1 commit into from
Feb 29, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

The feature can be enabled when we implemented it in CRI-O.

Which issue(s) this PR fixes:

Follow-up on #7765 (comment)
Refers to kubernetes-sigs/cri-tools#1344 (comment)

Special notes for your reviewer:

cc @giuseppe @AkihiroSuda

Does this PR introduce a user-facing change?

None

@saschagrunert
Disable Recursive Read-only (RRO) mounts feature
115e11d 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 29, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@kwilczynski
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@AkihiroSuda: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #7828 (115e11d) into main (d705c02) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7828      +/-   ##
==========================================
- Coverage   48.73%   48.71%   -0.02%     
==========================================
  Files         151      151              
  Lines       16287    16287              
==========================================
- Hits         7937     7935       -2     
- Misses       7386     7387       +1     
- Partials      964      965       +1

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-cgroupv2-integration

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-integration

In response to this:

/override ci/prow/ci-cgroupv2-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

giuseppe
giuseppe approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, giuseppe, kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-e2e-conmonrs

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-conmonrs

In response to this:

/override ci/prow/ci-e2e-conmonrs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9975449 into cri-o:main Feb 29, 2024
@saschagrunert saschagrunert deleted the rro-disable branch February 29, 2024 13:01
@saschagrunert saschagrunert mentioned this pull request Feb 29, 2024
Merged
3 tasks
This was referenced Apr 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

+1 more reviewer

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@giuseppe giuseppe

@kwilczynski kwilczynski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @kwilczynski @giuseppe @AkihiroSuda