fix seaweedfs s3 liveness probe scheme #1368
Conversation
Signed-off-by: IvanHunters <xorokhotnikov@gmail.com>
WalkthroughAdds a livenessProbe configuration under seaweedfs.s3 in packages/system/seaweedfs/values.yaml, specifying scheme: HTTPS, alongside the existing readinessProbe. No other fields are modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Summary of Changes
Hello @IvanHunters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a configuration detail for the SeaweedFS S3 service by explicitly setting its liveness probe to use HTTPS. This adjustment is crucial for ensuring that the service's health checks are performed securely and consistently with its readiness probe, thereby enhancing the overall stability and reliability of the deployment.
Highlights
- SeaweedFS S3 Liveness Probe: The liveness probe scheme for the SeaweedFS S3 service has been explicitly configured to use HTTPS in the
values.yamlfile. - Configuration Alignment: This change ensures consistency by aligning the liveness probe's scheme with the existing HTTPS configuration already present for the readiness probe.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the liveness probe scheme for the SeaweedFS S3 gateway to HTTPS. This change is necessary because security is enabled for the deployment, which causes the S3 gateway to serve traffic over HTTPS by default. My review includes a suggestion to add a comment to the configuration file to clarify this non-obvious behavior of SeaweedFS, which will improve future maintainability.
| livenessProbe: | ||
| scheme: HTTPS |
There was a problem hiding this comment.
This change correctly sets the liveness probe scheme to HTTPS, which is necessary when global.enableSecurity is true. To improve long-term maintainability, I suggest adding a comment to explain this non-obvious SeaweedFS behavior. This will help other developers understand why HTTPS is required for the probes in this configuration.
# When global.enableSecurity is true and no httpsPort is set, the S3 gateway
# serves HTTPS on the default port. The probe scheme must be HTTPS.
livenessProbe:
scheme: HTTPSThere was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/system/seaweedfs/values.yaml (1)
94-105: Ingress host vs TLS hosts mismatch may break TLS.
ingress.hostisseaweedfs2.demo.cozystack.io(Line 94) while TLShostscontainsseaweedfs.demo.cozystack.io(Line 104). This will request a certificate for a different hostname than the one routed, causing 404 on challenge or cert mismatch.Apply one of:
- Change TLS hosts to
seaweedfs2.demo.cozystack.io.- Or change
ingress.hosttoseaweedfs.demo.cozystack.io.Example fix:
- host: "seaweedfs2.demo.cozystack.io" + host: "seaweedfs.demo.cozystack.io" ... - - seaweedfs.demo.cozystack.io + - seaweedfs.demo.cozystack.io(Adjust to the intended hostname.)
🧹 Nitpick comments (1)
packages/system/seaweedfs/values.yaml (1)
87-88: Good fix; confirm the probe actually reaches an HTTPS endpoint and template wiring.Setting
livenessProbe.scheme: HTTPSaligns with readiness. Please verify:
- The S3 pod listens with TLS on the same port used by the probe (kubelet connects directly, not via Ingress).
- The chart’s templates actually read
.Values.seaweedfs.s3.livenessProbe.scheme(and not a different path) so this value takes effect.If supported by the chart, mirror this into a
startupProbe.scheme: HTTPSto avoid flapping during cold starts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/system/seaweedfs/values.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
<!-- Thank you for making a contribution! Here are some tips for you: - Start the PR title with the [label] of Cozystack component: - For system components: [platform], [system], [linstor], [cilium], [kube-ovn], [dashboard], [cluster-api], etc. - For managed apps: [apps], [tenant], [kubernetes], [postgres], [virtual-machine] etc. - For development and maintenance: [tests], [ci], [docs], [maintenance]. - If it's a work in progress, consider creating this PR as a draft. - Don't hesistate to ask for opinion and review in the community chats, even if it's still a draft. - Add the label `backport` if it's a bugfix that needs to be backported to a previous version. --> ## What this PR does ### Release note <!-- Write a release note: - Explain what has changed internally and for users. - Start with the same [label] as in the PR title - Follow the guidelines at https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md. --> ```release-note fix seaweedfs s3 liveness probe scheme ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added a liveness check for the SeaweedFS S3 endpoint (HTTPS). This improves health monitoring and enables automatic recovery if the service becomes unresponsive, enhancing stability and uptime while reducing manual intervention. Readiness behavior remains unchanged. No user action required. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
What this PR does
Release note
Summary by CodeRabbit