[fix] Disable VPA for VPA #1318

lllamnyp · 2025-08-07T10:39:26Z

The earlier PR was erroneously merged without including an amendment to the existing commits, so now this amendment must be included as a separate patch. See #1301 for details.

What this PR does

Release note

[]

Summary by CodeRabbit

Chores
- Updated configuration structure by moving the vpaForVPA setting to a top-level key in the default values for Vertical Pod Autoscaler. No changes to configuration values or functionality.

The earlier PR was erroneously merged without including an amendment to the existing commits, so now this amendment must be included as a separate patch. See #1301 for details. Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

coderabbitai · 2025-08-07T10:39:33Z

Walkthrough

The change moves the vpaForVPA: false configuration key from within the vertical-pod-autoscaler map to a top-level key in the Helm template for Vertical Pod Autoscaler. No other configuration changes or structural modifications are present.

Changes

Cohort / File(s)	Change Summary
Helm VPA config key relocation `packages/apps/kubernetes/templates/helmreleases/vertical-pod-autoscaler.yaml`	Moved `vpaForVPA: false` from under `vertical-pod-autoscaler` to a top-level key in the Helm template.

Sequence Diagram(s)

Not applicable for this change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

[kubernetes] Disable VPA for VPA in tenant k8s #1301: Both PRs modify the vpaForVPA configuration key in the same Helm chart template, with this PR relocating the key to a top-level position.
[platform] Autoscale the autoscaler #1198: This PR relocates the vpaForVPA key, while the related PR introduces a new Helm template and resources conditionally enabled by this key.

Suggested labels

backport

Suggested reviewers

klinch0

Poem

A key once nested, now stands tall,
Moved to the top, no longer small.
Helm charts rejoice, configs align,
Simpler to read, oh how divine!
🐇 With YAML in paw, I hop with glee,
For tidy charts bring harmony!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58def95 and ff3305f.

📒 Files selected for processing (1)

packages/apps/kubernetes/templates/helmreleases/vertical-pod-autoscaler.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: NickVolynkin
PR: cozystack/cozystack#1192
File: docs/changelogs/v0.34.0.md:15-17
Timestamp: 2025-08-05T07:17:29.755Z
Learning: The GitHub username lllamnyp is spelled with three 'l's, not two. This is the correct spelling for attribution in changelogs and documentation.

Learnt from: NickVolynkin
PR: cozystack/cozystack#1192
File: docs/changelogs/v0.34.0.md:15-17
Timestamp: 2025-08-05T07:17:29.755Z
Learning: The GitHub username lllamnyp is spelled with three 'l's, not two. This is the correct spelling for attribution in changelogs and documentation.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build

🔇 Additional comments (1)

packages/apps/kubernetes/templates/helmreleases/vertical-pod-autoscaler.yaml (1)

6-6: Breaking-change alert – vpaForVPA moved to root; confirm chart consumption & overrides

vpaForVPA was previously nested under vertical-pod-autoscaler. Moving it to the root level changes the lookup path to .Values.vpaForVPA.
Please verify:

The upstream cozy-vertical-pod-autoscaler chart reads the key from the new location; otherwise the flag will silently be ignored and VPA for VPA will be re-enabled.

Any valuesOverride supplied by tenants that still use the old nested path are migrated; mergeOverwrite on line 63 will not reconcile a nested key into the new root-level slot.

If either point is uncertain, consider keeping a compatibility shim or adding a deprecation notice in the chart’s values.yaml.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/no-vpa4vpa-in-tenant-k8s

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gemini-code-assist

Summary of Changes

Hello @lllamnyp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request corrects an oversight from a previous merge, ensuring that the "vpaForVPA" setting is correctly applied to disable VPA for VPA itself. This is crucial for preventing unintended behavior or resource consumption by ensuring the configuration is parsed at the intended scope.

Highlights

Configuration Correction: I've moved the "vpaForVPA: false" configuration entry in vertical-pod-autoscaler.yaml to the correct top-level scope. This rectifies an issue where this setting was previously nested incorrectly, preventing it from being properly applied.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request corrects the placement of the vpaForVPA setting within the cozystack.defaultVPAValues Helm template. By moving vpaForVPA: false to the top level, it aligns with the cozy-vertical-pod-autoscaler chart's expectation of accessing this value via .Values.vpaForVPA. This fixes a bug where the setting was at an incorrect path, ensuring the 'VPA for VPA' feature is correctly disabled by default. The change is correct and improves the configuration's robustness.

kvaps

LGTM

github-actions · 2025-08-07T10:53:59Z

Successfully created backport PR for release-0.34:

[Backport release-0.34] [fix] Disable VPA for VPA #1319

# Description Backport of #1318 to `release-0.34`.

[fix] Disable VPA for VPA

ff3305f

The earlier PR was erroneously merged without including an amendment to the existing commits, so now this amendment must be included as a separate patch. See #1301 for details. Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

lllamnyp requested review from kvaps and klinch0 as code owners August 7, 2025 10:39

lllamnyp added the backport Should change be backported on previus release label Aug 7, 2025

gemini-code-assist bot reviewed Aug 7, 2025

View reviewed changes

klinch0 approved these changes Aug 7, 2025

View reviewed changes

kvaps approved these changes Aug 7, 2025

View reviewed changes

kvaps merged commit c6bceff into main Aug 7, 2025
8 checks passed

kvaps deleted the fix/no-vpa4vpa-in-tenant-k8s branch August 7, 2025 10:53

github-actions bot mentioned this pull request Aug 7, 2025

[Backport release-0.34] [fix] Disable VPA for VPA #1319

Merged

kvaps added a commit that referenced this pull request Aug 7, 2025

[Backport release-0.34] [fix] Disable VPA for VPA (#1319)

3bca686

# Description Backport of #1318 to `release-0.34`.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[fix] Disable VPA for VPA #1318

[fix] Disable VPA for VPA #1318

Uh oh!

lllamnyp commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

kvaps left a comment

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

Uh oh!

[fix] Disable VPA for VPA #1318

[fix] Disable VPA for VPA #1318

Uh oh!

Conversation

lllamnyp commented Aug 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Release note

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

kvaps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

Uh oh!

lllamnyp commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)