Skip to content

dashboard auth-proxy enable cookie-secure #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

dashboard auth-proxy enable cookie-secure #1287

merged 2 commits into from
Aug 1, 2025

Conversation

klinch0
Copy link
Contributor

@klinch0 klinch0 commented Jul 30, 2025 •
edited by coderabbitai bot
Loading

What this PR does

  • dashboard auth-proxy enable cookie-secure

Release note

- dashboard auth-proxy enable cookie-secure

Summary by CodeRabbit

  • Chores
    • Updated Keycloak client redirect URI to use HTTPS instead of HTTP.
    • Improved authentication security by adjusting cookie and SSL settings.

@klinch0
keycloak enable cookie-secure
7918e28 
Signed-off-by: kklinch0 <kklinch0@gmail.com>
@klinch0 klinch0 requested review from kvaps and lllamnyp as code owners July 30, 2025 13:09
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 30, 2025 •
edited
Loading

Walkthrough

The redirect URI for the kubeapps-client Keycloak client was updated to use HTTPS instead of HTTP. Additionally, the kubeapps-auth-config ConfigMap had two flags removed: --ssl-insecure-skip-verify and --cookie-secure=false. No changes were made to exported or public entity declarations.

Changes

Cohort / File(s) Change Summary
Keycloak client and ConfigMap updates
packages/system/keycloak-configure/templates/configure-kk.yaml		 Updated the redirect URI from HTTP to HTTPS for kubeapps-client and removed two flags from kubeapps-auth-config's extraFlags.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~6 minutes

Suggested labels

enhancement

Poem

The dashboard’s now secure and bright,
HTTPS guides us through the night.
Old flags removed with gentle care,
For safer logins everywhere.
A cozy warren, snug and neat—
These changes make our hop complete! 🐇🔒

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7918e28 and 1ab6318.

📒 Files selected for processing (1)
  • packages/system/keycloak-configure/templates/configure-kk.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/system/keycloak-configure/templates/configure-kk.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch keycloak-fix-redirect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 30, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @klinch0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security posture of the dashboard's authentication process by enforcing secure cookie transmission and strengthening the Keycloak integration. It transitions the authentication flow to exclusively use HTTPS, removing previously insecure configurations.

Highlights

  • Security Enhancement: Enabled cookie-secure for the dashboard's authentication proxy by removing the --cookie-secure=false flag, ensuring cookies are only transmitted over secure (HTTPS) connections.
  • Keycloak Configuration Update: Updated the Keycloak client's redirect URI from HTTP to HTTPS and removed the --ssl-insecure-skip-verify flag, reinforcing secure communication practices and enabling SSL certificate verification.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 30, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances security by enabling secure cookies for the dashboard's authentication proxy. It updates the Keycloak client's redirect URI to use HTTPS and removes flags that disabled secure cookies and TLS certificate verification. A potential breaking change related to TLS certificate verification is noted, which could affect environments using self-signed certificates.

@klinch0 @lllamnyp
Update packages/system/keycloak-configure/templates/configure-kk.yaml
1ab6318 
Co-authored-by: Timofei Larkin <lllamnyp@gmail.com>
Signed-off-by: klinch0 <68821526+klinch0@users.noreply.github.com>
kvaps
kvaps approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps kvaps added the backport Should change be backported on previus release label Jul 31, 2025
@kvaps kvaps merged commit c81c9d2 into main Aug 1, 2025
19 checks passed
@kvaps kvaps deleted the keycloak-fix-redirect branch August 1, 2025 10:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2025

Successfully created backport PR for release-0.34:

@github-actions github-actions bot mentioned this pull request Aug 1, 2025
Merged
kvaps added a commit that referenced this pull request Aug 1, 2025
@kvaps
[Backport release-0.34] dashboard auth-proxy enable cookie-secure (#1291
1c62037 
)

# Description
Backport of #1287 to `release-0.34`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvaps kvaps kvaps approved these changes

@lllamnyp lllamnyp lllamnyp approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport Should change be backported on previus release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klinch0 @kvaps @lllamnyp