fix net pod policy #1232
fix net pod policy #1232
Conversation
WalkthroughThe changes increment the tenant application's version from 1.11.1 to 1.11.2, update the corresponding version mapping by fixing 1.11.1 to a commit hash and pointing 1.11.2 to HEAD, and extend the egress rules in the CiliumClusterwideNetworkPolicy by adding conditional blocks that allow traffic to pods labeled "vminsert" and "etcd" in namespaces derived from the release namespace hierarchy. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Helm Chart
participant NetworkPolicy
User->>Helm Chart: Deploy tenant app (v1.11.2)
Helm Chart->>NetworkPolicy: Apply updated egress rules
NetworkPolicy->>NetworkPolicy: Allow egress to "vminsert" and "etcd" pods in derived namespaces
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Summary of Changes
Hello @klinch0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on fixing the network pod policy for the tenant application. It achieves this by simplifying the existing Cilium Network Policy definition, removing a set of rules that were likely causing issues or were no longer required. This change is accompanied by a standard version update for the tenant application.
Highlights
- Network Policy Simplification: The core change involves removing a significant block of
toEndpointsrules from thetenantapplication'snetworkpolicy.yaml. This simplification likely addresses an issue with the previous policy's behavior or necessity, streamlining network access for tenant pods. - Version Increment: The
tenantapplication's Helm chart version has been bumped from1.11.1to1.11.2, indicating a new release incorporating this network policy fix.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to fix a network policy for tenant pods. The main change involves removing a broad egress rule from the CiliumClusterwideNetworkPolicy that allowed pods in a child tenant to communicate with its parent tenant's namespace. While this appears to be a security hardening measure, it potentially contradicts the documented behavior where child tenants can use services from their parent. I've raised a critical issue requesting clarification on this point to ensure no functionality is unintentionally broken. The PR also includes corresponding version bumps for the tenant chart.
Signed-off-by: kklinch0 <kklinch0@gmail.com>
2c73e17 to
6598213
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
packages/apps/tenant/templates/networkpolicy.yaml (1)
57-69: Consolidate duplicated hierarchy loop into a helper templateThe second block for
etcdis an almost-verbatim copy of thevminsertrule, differing only in one label key/value. This duplication:
- inflates the template,
- makes future edits error-prone,
- and hides the intent of “allow egress to hierarchical tenant services”.
Extract a small helper (e.g.
_hierarchicalToEndpoints) that accepts the service label key/value and emits the loopedmatchLabelslist. Both blocks then become one-liners that call the helper with"app.kubernetes.io/name", "vminsert"and"app.kubernetes.io/instance", "etcd"respectively.Refactoring keeps the policy DRY and easier to reason about.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/apps/tenant/Chart.yaml(1 hunks)packages/apps/tenant/templates/networkpolicy.yaml(1 hunks)packages/apps/versions_map(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/apps/versions_map
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/apps/tenant/Chart.yaml
🧰 Additional context used
🪛 YAMLlint (1.37.1)
packages/apps/tenant/templates/networkpolicy.yaml
[error] 56-56: trailing spaces
(trailing-spaces)
|
Successfully created backport PR for |
# Description Backport of #1232 to `release-0.34`.
What this PR does
Release note
Summary by CodeRabbit
Chores
New Features