-
-
Notifications
You must be signed in to change notification settings - Fork 293
Fix meshes not centering when created using buffers #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Definitely looks better in your example. 😄 |
Fix/mesh obfuscation
depilz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Reason I haven't merged it yet is because of backward compatibility. Do you think it'll break existing apps? |
@Shchvova Yeah, maybe the |
Actually both of them need the center mesh code, I took it from the non-fromVertices and now it's being applied to both cases (pure Lua and buffered) This is an initialization call, so centering the mesh will always be required. Also the pure Lua version logic remains intact, the one that changed is the one using buffers so there shouldn't be any danger in this change. |
@Shchvova I was looking over some of the code with @depilz and it seems like the vertex offset calculation is almost replicated in the tessellator's This doesn't affect the correctness, but seems like a legitimate optimization—meshes can have plenty of points, after all. Off-hand I didn't see if the situation would always occur or if the rect would want to be an optional input to |
Testing branch using lua tables to update meshes. CleanShot.2025-05-28.at.13.05.53.mp4Testing branch using buffered memory data to update meshes. CleanShot.2025-05-28.at.13.11.35.mp4They both look equally good but buffered is definitely a great improvement in performance . @Shchvova this branch is ready to go. Can we merge it in? |
Fixes this:
CleanShot.2025-01-16.at.18.01.58.mp4
Result:
CleanShot.2025-01-16.at.18.02.16.mp4
@ggcrunchy does this looks good to you?