deps: bump cosmos-sdk to v0.50.9 #6828

damiannolan · 2024-07-15T13:46:26Z

Description

closes: #6822 #6825 #6827 #6826 #6824 #6823

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

….1.4

damiannolan · 2024-07-15T14:35:35Z

There looks to be some failing unit tests here

crodriguezvega

Thanks, @damiannolan!

damiannolan · 2024-07-15T15:35:35Z

Let's hold off on merging this until we understand why this change broke our tests:

cc. @julienrbrt @tac0turtle

I'm unsure what the implications of this change really means, so would be nice to understand it better. (edit: I see this is for supporting nested any's from the perspective of multisig keys. Seems like there is not symmetry between LegacyAminoPubKey when created with kmultisig.NewLegacyAminoPubKey() (packPubKeys) and unmarshalled LegacyAminoPubKey which use the AnyUnpacker interface.).

I could get the tests passing again with:

diff --git a/crypto/keys/multisig/multisig.go b/crypto/keys/multisig/multisig.go
index e28aa012d8..e31a48170b 100644
--- a/crypto/keys/multisig/multisig.go
+++ b/crypto/keys/multisig/multisig.go
@@ -156,6 +156,12 @@ func (m *LegacyAminoPubKey) UnpackInterfaces(unpacker types.AnyUnpacker) error {
                if err != nil {
                        return err
                }
+
+               if pk != nil {
+                       if err = any.UnmarshalAmino(pk.Bytes()); err != nil {
+                               return err
+                       }
+               }
        }
        return nil
 }
(END)

Would like to get a better understanding of any.compat, I see it gets unset here explicitly too (https://github.com/cosmos/cosmos-sdk/blob/v0.50.8/codec/types/compat.go#L98-L100)

crodriguezvega · 2024-07-15T18:08:31Z

I will close in the meantime the other dependabot PRs to reduce the noise...

DimitrisJim · 2024-08-05T07:19:59Z

well shit, that did not work, changelog for tx mentioned reversion cosmos/cosmos-sdk@564cc4d which I thought was issue?

at least I addressed the conflicts, commit that Damian was using before was github.com/cosmos/cosmos-sdk v0.50.9-0.20240722112539-25d481f797ca (dropping here just in case)

julienrbrt · 2024-08-06T15:15:19Z

Could you try out with the latest commit from release/v0.50.x? 3f6796fba413cca7f2ea9a7e03d7965e7eda7378

julienrbrt · 2024-08-06T15:15:38Z

Once you confirm it works, we can release v0.50.9.

DimitrisJim · 2024-08-07T07:06:18Z

@julienrbrt all seems green in the run. Thanks for the fix and ping!

CHANGELOG.md

sonarqubecloud · 2024-08-07T10:11:42Z

Quality Gate passed for 'ibc-go'

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* deps: bump cosmos-sdk to v0.50.8 * chore: update changelog * deps: bump cosmossdk.io/client to v2.0.0-beta.3. bump x/upgrade to v0.1.4 * chore: make tidy-all * test: bump to 3f6796fba413cca for testing purposes. * deps: bump cosmos sdk to 0.50.9 * Update CHANGELOG.md * chore: update CHANGELOG for submodules. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 3425726) # Conflicts: # e2e/go.mod # e2e/go.sum # modules/light-clients/08-wasm/CHANGELOG.md

* deps: bump cosmos-sdk to v0.50.9 (#6828) * deps: bump cosmos-sdk to v0.50.8 * chore: update changelog * deps: bump cosmossdk.io/client to v2.0.0-beta.3. bump x/upgrade to v0.1.4 * chore: make tidy-all * test: bump to 3f6796fba413cca for testing purposes. * deps: bump cosmos sdk to 0.50.9 * Update CHANGELOG.md * chore: update CHANGELOG for submodules. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 3425726) # Conflicts: # e2e/go.mod # e2e/go.sum # modules/light-clients/08-wasm/CHANGELOG.md * remove e2e folder * chore: fix 08-wasm CHANGELOG conflict. --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

* deps: bump cosmos-sdk to v0.50.9 (#6828) * deps: bump cosmos-sdk to v0.50.8 * chore: update changelog * deps: bump cosmossdk.io/client to v2.0.0-beta.3. bump x/upgrade to v0.1.4 * chore: make tidy-all * test: bump to 3f6796fba413cca for testing purposes. * deps: bump cosmos sdk to 0.50.9 * Update CHANGELOG.md * chore: update CHANGELOG for submodules. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * chore(api!): move checks from Transfer to OnSendPacket * Fix merge error * fix to test * Add Require() back * Update modules/apps/transfer/ibc_module.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Linter * Removed wrong merge results * reintroduce test * Move check for isSendEnabledCoins to keeper * new tests * fixed test * linter * Removed checks and added comment * removed extra parentheses * Revert "Merge remote-tracking branch 'origin' into bznein/6949/msgTransferWrapperToSendPacket" This reverts commit be9f558, reversing changes made to 36e4b05. * Delete commented out code --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* deps: bump cosmos-sdk to v0.50.8 * chore: update changelog * deps: bump cosmossdk.io/client to v2.0.0-beta.3. bump x/upgrade to v0.1.4 * chore: make tidy-all * test: bump to 3f6796fba413cca for testing purposes. * deps: bump cosmos sdk to 0.50.9 * Update CHANGELOG.md * chore: update CHANGELOG for submodules. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 3425726) # Conflicts: # CHANGELOG.md # e2e/go.mod # e2e/go.sum # go.mod # go.sum # modules/apps/callbacks/CHANGELOG.md # modules/apps/callbacks/go.mod # modules/apps/callbacks/go.sum # modules/capability/CHANGELOG.md # modules/capability/go.mod # modules/light-clients/08-wasm/CHANGELOG.md # modules/light-clients/08-wasm/go.mod # modules/light-clients/08-wasm/go.sum # simapp/go.mod # simapp/go.sum

* deps: bump cosmos-sdk to v0.50.9 (#6828) * deps: bump cosmos-sdk to v0.50.8 * chore: update changelog * deps: bump cosmossdk.io/client to v2.0.0-beta.3. bump x/upgrade to v0.1.4 * chore: make tidy-all * test: bump to 3f6796fba413cca for testing purposes. * deps: bump cosmos sdk to 0.50.9 * Update CHANGELOG.md * chore: update CHANGELOG for submodules. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 3425726) # Conflicts: # CHANGELOG.md # e2e/go.mod # e2e/go.sum # go.mod # go.sum # modules/apps/callbacks/CHANGELOG.md # modules/apps/callbacks/go.mod # modules/apps/callbacks/go.sum # modules/capability/CHANGELOG.md # modules/capability/go.mod # modules/light-clients/08-wasm/CHANGELOG.md # modules/light-clients/08-wasm/go.mod # modules/light-clients/08-wasm/go.sum # simapp/go.mod # simapp/go.sum * fix conflicts * callbacks: go mod tidy * tidy --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* Update CHANGELOG.md * fix(ica-host): refactor newModuleQuerySafeAllowList to avoid panic (backport cosmos#6436) (cosmos#6520) * fix(ica-host): refactor newModuleQuerySafeAllowList to avoid panic (cosmos#6436) * fix(ica-host): refactor newModuleQuerySafeAllowList to avoid panic due to AllowUnresolvable field * add changelog entry * Apply suggestions from code review Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit a16c549) # Conflicts: # CHANGELOG.md * fix conflicts in changelog. --------- Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * deps(release/v8.3.x): bump SDK to v0.50.7 (cosmos#6614) * deps: bump SDK to v0.50.7 * add changelog * update changelog before v8.3.2 release * Update CHANGELOG.md * events: add channel ordering to write acknowledgement event (cosmos#6867) (cosmos#6871) * docs: remove ordering from write ack event and non-hex data atrributes * rever doc changes * add ordering to write acknowledgement event * Update events.md (cherry picked from commit 352ba6e) Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * (feat) Add possibility to transfer entire balance. (backport cosmos#6877) (cosmos#6930) * (feat) Add possibility to transfer entire balance. (cosmos#6877) * Add possibility to transfer entire balance. * Added entry to the Changelog. * Added e2e test * Added forwarding * Update modules/apps/transfer/keeper/relay.go Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * Move UnboundedSpendLimit to token.go * add documentation * add test to compatibility matrices * PR Feedback. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 92e1f38) # Conflicts: # .github/compatibility-test-matrices/main/transfer-v2-multidenom-chain-a.json # .github/compatibility-test-matrices/release-v9.0.x/transfer-v2-multidenom-chain-a.json # .github/compatibility-test-matrices/unreleased/transfer-v2-multidenom.json # CHANGELOG.md # docs/docs/02-apps/01-transfer/04-messages.md # docs/docs/02-apps/01-transfer/10-ICS20-v1/04-messages.md # e2e/tests/transfer/base_test.go # modules/apps/transfer/keeper/relay.go # modules/apps/transfer/keeper/relay_test.go # modules/apps/transfer/types/token.go # modules/apps/transfer/types/transfer_authorization.go * fix conflicts * remove unused code --------- Co-authored-by: Nikolas De Giorgis <nikolas.degiorgis@interchain.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * fix(state!): check upgrade compatibility in channel upgrade confirm (backport cosmos#6935) (cosmos#6944) * fix(state!): check upgrade compatibility in channel upgrade confirm (cosmos#6935) (cherry picked from commit 3a192be) # Conflicts: # CHANGELOG.md * fix conflicts --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * update changelog before v8.4.0 release * retract v8.2.x and v8.3.x (cosmos#6965) Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * backport-v8.5.x: self client/consensus state removal from connection handshake (cosmos#7129) * refactor: remove client/consensus state validation from connection handshake * chore: generate proto deprecation notice * add changelog * refactor: remove unpacking from msg server * deps(release/v8.5.x): bump ics23 to v0.11.0 (cosmos#7222) * deps: bump ics23 to v0.11.0-rc.0 * deps: bump ics23 to v0.11.0 * deps: bump cosmos-sdk to v0.50.9 (backport cosmos#6828) (cosmos#7227) * deps: bump cosmos-sdk to v0.50.9 (cosmos#6828) * deps: bump cosmos-sdk to v0.50.8 * chore: update changelog * deps: bump cosmossdk.io/client to v2.0.0-beta.3. bump x/upgrade to v0.1.4 * chore: make tidy-all * test: bump to 3f6796fba413cca for testing purposes. * deps: bump cosmos sdk to 0.50.9 * Update CHANGELOG.md * chore: update CHANGELOG for submodules. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 3425726) # Conflicts: # CHANGELOG.md # e2e/go.mod # e2e/go.sum # go.mod # go.sum # modules/apps/callbacks/CHANGELOG.md # modules/apps/callbacks/go.mod # modules/apps/callbacks/go.sum # modules/capability/CHANGELOG.md # modules/capability/go.mod # modules/light-clients/08-wasm/CHANGELOG.md # modules/light-clients/08-wasm/go.mod # modules/light-clients/08-wasm/go.sum # simapp/go.mod # simapp/go.sum * fix conflicts * callbacks: go mod tidy * tidy --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update CHANGELOG.md * Update CHANGELOG.md * fix: attempt to fix panics for unresolvable imports by using GogoResolver (backport cosmos#7277) (cosmos#7281) * fix: attempt to fix panics for unresolvable imports by using GogoResolver (cosmos#7277) * fix: attempt to fix panics for unresolvable imports by using GogoResolver * chore: add changelog * chore: amend changelog (cherry picked from commit 79ddda5) # Conflicts: # CHANGELOG.md * chore: address merge conflicts in changelog --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> * prepare changelog for v8.5.1 release * Update CHANGELOG.md * fix: avoid invalid identifier error when validate genesis (backport cosmos#7397) (cosmos#7403) * fix: avoid invalid identifier error when validate genesis (cosmos#7397) * fix: avoid invalid identifier error when validate genesis that contains localhost client * Apply suggestions from code review * skip (cherry picked from commit ff2b668) # Conflicts: # CHANGELOG.md # modules/core/03-connection/types/genesis.go # modules/core/03-connection/types/genesis_test.go * chore: changelog cleanup * chore: fix imports --------- Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com> * test: update block proposer in testing (backport cosmos#7430) (cosmos#7453) * test: update block proposer in testing (cosmos#7430) * Introduce two following changes to the `commitBlock` method in testing: * increment the proposer priority of validators * update the proposer address in the current header * fix linter (cherry picked from commit 64f33e0) # Conflicts: # testing/chain.go * why did you fail us here, mergify my boy --------- Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * Updating changelog for v8.5.2 (cosmos#7536) * chore: backport json tags for Height for ibc client proto (cosmos#7868) * chore: update changelog for v8.5.3 (cosmos#7876) * Chore/revert ibc proto updates (cosmos#7887) * Revert "chore: update changelog for v8.5.3 (cosmos#7876)" This reverts commit c3af326. * Revert "chore: backport json tags for Height for ibc client proto (cosmos#7868)" This reverts commit b589a85. * chore: retract v8.5.3 (cosmos#7888) * chore: retract v8.5.3 * fix retract statement * chore: update changelog and redact * Merge commit from fork rm test case * chore: update redacted * fix: remove packet data remarshaling (cosmos#8065) * fix: remove packet data remarshaling * chore: update upload artifact * chore: update download artifact * redact 8.6.0 * ignoring packages that have no tests, else make test and make test-all fail. --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Nikolas De Giorgis <nikolas.degiorgis@interchain.io> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: PaddyMc <paddymchale@hotmail.com> Co-authored-by: Gjermund Garaba <gjermund@garaba.net> Co-authored-by: Aditya <14364734+AdityaSripal@users.noreply.github.com>

deps: bump cosmos-sdk to v0.50.8

b1e021b

damiannolan marked this pull request as ready for review July 15, 2024 13:46

damiannolan requested review from colin-axner, AdityaSripal, srdtrk, chatton, DimitrisJim, crodriguezvega, gjermundgaraba and bznein as code owners July 15, 2024 13:46

chore: update changelog

d1f2f51

crodriguezvega added backport-to-v8.2.x and removed backport-to-v8.2.x labels Jul 15, 2024

deps: bump cosmossdk.io/client to v2.0.0-beta.3. bump x/upgrade to v0…

a910874

….1.4

crodriguezvega approved these changes Jul 15, 2024

View reviewed changes

damiannolan mentioned this pull request Jul 17, 2024

fix(crypto/multisig): set compat.AminoBz when unpacking interfaces cosmos/cosmos-sdk#20972

Closed

12 tasks

colin-axner approved these changes Jul 17, 2024

View reviewed changes

chore: make tidy-all

4793166

DimitrisJim force-pushed the deps/sdk-bump branch from 73e9fde to 4793166 Compare August 2, 2024 14:11

DimitrisJim marked this pull request as ready for review August 2, 2024 14:12

DimitrisJim mentioned this pull request Aug 2, 2024

chore(deps): bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 in /modules/apps/callbacks #7038

Closed

test: bump to 3f6796fba413cca for testing purposes.

f93d0fe

deps: bump cosmos sdk to 0.50.9

f5c5475

DimitrisJim changed the title ~~deps: bump cosmos-sdk to v0.50.8~~ deps: bump cosmos-sdk to v0.50.9 Aug 7, 2024

Merge branch 'main' into deps/sdk-bump

ba0348b

DimitrisJim reviewed Aug 7, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

DimitrisJim added 2 commits August 7, 2024 12:56

Update CHANGELOG.md

353b52b

chore: update CHANGELOG for submodules.

d8b9140

DimitrisJim approved these changes Aug 7, 2024

View reviewed changes

DimitrisJim added this pull request to the merge queue Aug 7, 2024

Merged via the queue into main with commit 3425726 Aug 7, 2024
76 of 78 checks passed

DimitrisJim deleted the deps/sdk-bump branch August 7, 2024 10:42

mergify bot mentioned this pull request Aug 7, 2024

deps: bump cosmos-sdk to v0.50.9 (backport #6828) #7065

Merged

10 tasks

crodriguezvega added the backport-to-v8.5.x label Aug 29, 2024

mergify bot mentioned this pull request Aug 29, 2024

deps: bump cosmos-sdk to v0.50.9 (backport #6828) #7227

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: bump cosmos-sdk to v0.50.9 #6828

deps: bump cosmos-sdk to v0.50.9 #6828

Uh oh!

damiannolan commented Jul 15, 2024 •

edited

Loading

Uh oh!

damiannolan commented Jul 15, 2024

Uh oh!

crodriguezvega left a comment

Uh oh!

damiannolan commented Jul 15, 2024 •

edited

Loading

Uh oh!

crodriguezvega commented Jul 15, 2024

Uh oh!

DimitrisJim commented Aug 5, 2024

Uh oh!

julienrbrt commented Aug 6, 2024

Uh oh!

julienrbrt commented Aug 6, 2024

Uh oh!

DimitrisJim commented Aug 7, 2024

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 7, 2024

Uh oh!

Uh oh!

Uh oh!

deps: bump cosmos-sdk to v0.50.9 #6828

deps: bump cosmos-sdk to v0.50.9 #6828

Uh oh!

Conversation

damiannolan commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

damiannolan commented Jul 15, 2024

Uh oh!

crodriguezvega left a comment

Choose a reason for hiding this comment

Uh oh!

damiannolan commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crodriguezvega commented Jul 15, 2024

Uh oh!

DimitrisJim commented Aug 5, 2024

Uh oh!

julienrbrt commented Aug 6, 2024

Uh oh!

julienrbrt commented Aug 6, 2024

Uh oh!

DimitrisJim commented Aug 7, 2024

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 7, 2024

Quality Gate passed for 'ibc-go'

Uh oh!

Uh oh!

Uh oh!

damiannolan commented Jul 15, 2024 •

edited

Loading

damiannolan commented Jul 15, 2024 •

edited

Loading