Skip to content

Queue a partially-pulled layer for commit immediately after staging it #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Mar 20, 2025

Don't block all other layer commits until all layers are downloaded / staged.

Fixes #2798 .

Marked as draft: Absolutely untested, filing early just to make this public.

@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Mar 21, 2025
mtrmac added a commit to mtrmac/libpod that referenced this pull request May 31, 2025
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac added a commit to mtrmac/libpod that referenced this pull request May 31, 2025
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Collaborator Author

mtrmac commented May 31, 2025

Now manually tested by adding a log entry at the top of createNewLayer, confirming this changes layer commit timing.

Podman tests are running in containers/podman#26249 .

@giuseppe PTAL.

@mtrmac mtrmac marked this pull request as ready for review May 31, 2025 00:26
mtrmac added a commit to mtrmac/libpod that referenced this pull request May 31, 2025
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Don't block all other layer commits until all layers are downloaded
/ staged.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jun 2, 2025

Podman tests are ~passing.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrmac mtrmac merged commit 347a6e7 into containers:main Jun 3, 2025
10 checks passed
@mtrmac mtrmac deleted the partial-commit branch June 3, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No blob reuse with zstd:chunked partial pull, even when ConcurrentBlobCopiesSemaphore concurrency is 1
2 participants