-
Notifications
You must be signed in to change notification settings - Fork 402
[release-5.34] Bump c/storage to v1.57.2, c/image to v5.34.2 #2765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-5.34] Bump c/storage to v1.57.2, c/image to v5.34.2 #2765
Conversation
Bump c/storage to v1.57.2 to force idm map private propacation per containers/storage#2269 This is targeted for RHEL 9.6/10.0 ZeroDay. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Bump to c/image v5.34.2 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Can we not do this? I don't understand the purpose of this bump since there are no changes in c/image. There is no need to strictly bump c/image and c/common just because there is a new c/storage unless there are actual changes in them. We can directly bump c/storage in podman, buildah, skopeo which works the same. I am saying this because each of these releases puts extra burden on us, not just the extra release PR, the new version then triggers downgrades per go modules versions until we merge back branches which is annoying to deal with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mechanics of this PR LGTM.
As for whether c/image should have a tag, I don’t feel strongly (and I think we might have had such a discussion earlier, I’m not sure).
I’ll leave this open to give the discussion space, but feel free to merge if that’s the outcome.
Yeah to be clear I agree that this is totally fine to do. But I think we can safe us some work by not doing it as I don't see this doing anything beneficial either. |
during the process of finding the problem, the way that contains related lib or bin is a little bit heavy, sometimes chainable release will introduce extra work, maybe |
We are aware of how this works, the tag here does not contribute to any solution though it makes things worse because now c/image 5.34.2 would be newer than its main branch as well. The only way as I already have written above is to merge back each tag after the release into main
And now containers/storage#2276 once that is merged c/storage@main will be update over 1.57.2 |
Although not needed from a Go compatibility perspective, before doing a release, like we are now for the RHEL Zero Day release, I very much prefer aligning the version numbers up and down the stack. It might be my OCD silliness, but I find it easier a year or more after a release to try and find what was where and what needs to bump. When I see c/storage 1.57.3 in Buildah, but 1.57.1 in image, I always end up digging more and second-guessing. Yes a bit more grind for the team, but generally a very quick review. If we could push this through, I would appreciate it. |
Let’s stay consistent, then. |
Bump c/storage to v1.57.2 to force idmap private
propagation per containers/storage#2269
Then c/image to v5.34.2
This is targeted for RHEL 9.6/10.0 ZeroDay.