-
-
Notifications
You must be signed in to change notification settings - Fork 428
Minor changes to support local builds and custom micromamba download locations #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated to use the LOCALAPPDATA environment variable instead of the hard-coded runner username. This will help to avoid script changes if someone is trying to build a custom installer locally. Signed-off-by: Kevin Mills <millsks@gmail.com>
…rom conda-forge Signed-off-by: Kevin Mills <millsks@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
This will show the error message when miniforge is already installed in prefix path referenced by the installation process. Signed-off-by: Kevin Mills <millsks@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
The custom channel would be accessible if conda-forge was not due to internal network restrictions. Signed-off-by: Kevin Mills <millsks@gmail.com>
@conda-forge-admin, please rerender |
Signed-off-by: Kevin Mills <millsks@gmail.com>
@conda-forge/miniforge ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather use the prefix MINIFORGE_
instead of CF_
for variables that are for this project.
Otherwise, seems sane.
Agreed. I'll get it updated tonight. |
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
@hmaarrfk Made all suggested changes. |
Who do you work for and what do you use to host your mirror? |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Resolves #746
Resolves #747
Resolves #748