Skip to content

Conversation

millsks
Copy link
Contributor

@millsks millsks commented Mar 16, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Resolves #746
Resolves #747
Resolves #748

millsks added 8 commits March 16, 2025 14:12
Updated to use the LOCALAPPDATA environment variable instead of the hard-coded runner username. This will help to avoid script changes if someone is trying to build a custom installer locally.

Signed-off-by: Kevin Mills <millsks@gmail.com>
…rom conda-forge

Signed-off-by: Kevin Mills <millsks@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
This will show the error message when miniforge is already installed in prefix path referenced by the installation process.

Signed-off-by: Kevin Mills <millsks@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
The custom channel would be accessible if conda-forge was not due to internal network restrictions.

Signed-off-by: Kevin Mills <millsks@gmail.com>
@millsks millsks requested a review from a team as a code owner March 16, 2025 20:51
@millsks
Copy link
Contributor Author

millsks commented Mar 16, 2025

@conda-forge-admin, please rerender

Signed-off-by: Kevin Mills <millsks@gmail.com>
@millsks
Copy link
Contributor Author

millsks commented Mar 16, 2025

@conda-forge/miniforge ready for review.

Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather use the prefix MINIFORGE_ instead of CF_ for variables that are for this project.

Otherwise, seems sane.

@millsks
Copy link
Contributor Author

millsks commented Mar 17, 2025

I would rather use the prefix MINIFORGE_ instead of CF_ for variables that are for this project.

Otherwise, seems sane.

Agreed. I'll get it updated tonight.

millsks and others added 3 commits March 16, 2025 19:38
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Signed-off-by: Kevin Mills <millsks@gmail.com>
@millsks millsks requested a review from hmaarrfk March 17, 2025 00:41
@millsks
Copy link
Contributor Author

millsks commented Mar 17, 2025

@hmaarrfk Made all suggested changes.

@hmaarrfk hmaarrfk merged commit 0226fe5 into conda-forge:main Mar 17, 2025
7 of 8 checks passed
@hmaarrfk
Copy link
Contributor

Who do you work for and what do you use to host your mirror?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants