Skip to content

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Aug 22, 2023

Description

Closes #4976

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @woutdenolf.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#806), and ping the bot to refresh the PR.

@woutdenolf woutdenolf force-pushed the 4976-merge_tree-bug-in-checking-for-subdirectory branch from f86cee9 to 5c9eeb3 Compare August 22, 2023 20:49
@dbast
Copy link
Member

dbast commented Aug 22, 2023

@conda-bot check-cla

@woutdenolf woutdenolf force-pushed the 4976-merge_tree-bug-in-checking-for-subdirectory branch from 5c9eeb3 to 7d11395 Compare August 22, 2023 20:54
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 22, 2023
@woutdenolf
Copy link
Contributor Author

For reference, this is a fix of another fix: #1546

Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

1 similar comment
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Sep 20, 2024
@woutdenolf woutdenolf force-pushed the 4976-merge_tree-bug-in-checking-for-subdirectory branch from 7d11395 to 7c54a95 Compare September 20, 2024 07:29
@woutdenolf woutdenolf requested a review from a team as a code owner September 20, 2024 07:29
@woutdenolf
Copy link
Contributor Author

I rebased again on main.

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Sep 21, 2024
Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #4977 will not alter performance

Comparing woutdenolf:4976-merge_tree-bug-in-checking-for-subdirectory (5fe1a03) with main (6e6bb13)

Summary

✅ 5 untouched benchmarks

beckermr
beckermr previously approved these changes Feb 27, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Approved in 🔎 Review Feb 27, 2025
@beckermr
Copy link
Contributor

Well this is annoying? IIUIC, the test suite is failing on deprecations that have not been addressed within conda. That shouldn't block conda build PRs.

Did I get that right?

Ideas @jezdez @jaimergp @kenodegard ?

@jezdez
Copy link
Member

jezdez commented Feb 27, 2025

@beckermr Yeah, we recently changed the conda.plan upstream in conda/conda#14603, which is why this is showing up for canary tests now. I've added the line to the config to ignore the pending deprecation for now (as we've done before).

@beckermr
Copy link
Contributor

Ah thank you @jezdez!

@beckermr beckermr self-requested a review February 27, 2025 15:22
@beckermr beckermr enabled auto-merge (squash) February 27, 2025 15:23
@beckermr beckermr merged commit bfb9496 into conda:main Feb 27, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Feb 27, 2025
@kenodegard kenodegard mentioned this pull request Mar 18, 2025
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA stale::recovered [bot] recovered after being marked as stale
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

merge_tree: bug in checking for subdirectory
6 participants