Build plan visibility #3392
Merged
Build plan visibility #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2116 Signed-off-by: Josh Winters <jwinters@pivotal.io> Co-authored-by: Mark Huang <mhuang@pivotal.io>
|
Over to you @pivotal-jamie-klassen @xtreme-james-cooper |
added 2 commits
March 13, 2019 10:34
#3392 Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
#2116 Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
| -> Html Msg | ||
| body { currentBuild, authorized, showHelp } = | ||
| Html.div [ class "scrollable-body build-body" ] <| | ||
| if authorized then |
There was a problem hiding this comment.
Breaking this garbage 10,000-line function up. YESSSSSSSSSS
| @@ -100,60 +100,37 @@ handleStepTreeMsg action model = | |||
|
|
|||
| planAndResourcesFetched : | |||
| Concourse.BuildId | |||
| -> Result Http.Error ( Concourse.BuildPlan, Concourse.BuildResources ) | |||
| -> ( Concourse.BuildPlan, Concourse.BuildResources ) | |||
There was a problem hiding this comment.
...Hrmmm. I get that the tuple is easier to pass from the caller, it just seems... odd.
vito
requested changes
Mar 18, 2019
|
@pivotal-jamie-klassen mind rebasing this? The golang merge is pretty straight forward. I got part way through the elm stuff and wasn't sure what needed to be kept. |
Signed-off-by: James Cooper <jcooper@pivotal.io> Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
vito
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show the build plan for private jobs.
fixes #2116