atc: enhance container memory unit parsing with IEC notation support #9130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for IEC standard notation (KiB, MiB, GiB) alongside the existing traditional units (KB, MB, GB). Improve the regex pattern to handle abbreviated units (K, M, G) and ensure case insensitivity across all unit formats. No functional change to existing behavior - all units continue to use binary multipliers (2^10, 2^20, 2^30) as before. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
|
Should we validate limits too? Like there doesn't seem a point in setting limits < 256kb? |
taylorsilva
approved these changes
May 12, 2025
There was a problem hiding this comment.
Docs should be updated: https://github.com/concourse/docs/blob/c7b8d360dfe2ca7ddef04b359dcfa42a6b8d7811/lit/docs/tasks.lit#L287-L290
They don't even mention the current state correctly of being able to use KB/MB/KB
taylorsilva
added a commit
to concourse/docs
that referenced
this pull request
May 12, 2025
Found this wasn't documented while reviewing concourse/concourse#9130 Signed-off-by: Taylor Silva <dev@taydev.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor memory unit parsing to improve code clarity and maintainability.
The existing implementation was already using the correct binary multipliers
(2^10, 2^20, 2^30) but with a less clear approach of using powers.
Add support for IEC standard notation (KiB, MiB, GiB) alongside the traditional
units (KB, MB, GB) and abbreviated forms (K, M, G). Fix case sensitivity
issues with a proper case-insensitive regex pattern.