Use github.com/google/uuid to generate UUIDv4 #9083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com> Co-authored-by: Taylor Silva <dev@taydev.net>
In the case where we failed to create a container we would log the error twice in the web node and also mark it as failed twice. The second call to mark the container as failed would itself fail and return an error because the container is already marked as failed. Signed-off-by: Taylor Silva <dev@taydev.net>
We found UUID collisions occuring in our cluster. We thought it was impossible but I decided to look into the library we were using for UUID generation and found this issue: nu7hatch/gouuid#28 Which would explain some of the errors I've seen where the only possible explanation was that we got the same UUID twice. Signed-off-by: Taylor Silva <dev@taydev.net>
analytically
approved these changes
Feb 25, 2025
taylorsilva
added a commit
to concourse/s3-resource
that referenced
this pull request
Feb 25, 2025
See concourse/concourse#9083 for details Also made some nitpick updates based on gopls deprecation warnings Signed-off-by: Taylor Silva <dev@taydev.net>
taylorsilva
added a commit
to concourse/s3-resource
that referenced
this pull request
Feb 25, 2025
See concourse/concourse#9083 for details Also made some nitpick updates based on gopls deprecation warnings Signed-off-by: Taylor Silva <dev@taydev.net>
taylorsilva
added a commit
to concourse/semver-resource
that referenced
this pull request
Feb 25, 2025
See concourse/concourse#9083 for details Signed-off-by: Taylor Silva <dev@taydev.net>
91ae9da to
5abd00f
Compare
on systems where the test was slow to run it seemed that this testing of the batch duration would flake a lot. I think there was also a general race condition from accessing the NewRelicBatch array since it does get cleared out in a go routine. I left NewRelicBatch public still because it makes the testing setup easier, but now there's a Batch() function that can be used to safely access the array. Signed-off-by: Taylor Silva <dev@taydev.net>
5abd00f to
44b6782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
We found UUID collisions occurring in our cluster. We thought it was
impossible but I decided to look into the library we were using for UUID
generation and found this issue: nu7hatch/gouuid#28
Which would explain some of the errors I've seen where the only possible
explanation was that we got the same UUID twice.
Notes to reviewer
The error we were seeing was this:
I dug into how we generate this handle and found we use the
nu7hatch/gouuidto generate the UUID. We trusted that this UUID would be truly random so of course the database doesn't have any protections against two containers being made with the same handle. We also don't do any checks ourselves that the handle has been used. Doing so would be a waste of CPU for the web and database assuming that your UUID library generates unique UUID's.I'm trusting this new library more since it is maintained by Google and they're probably using this in their own production apps.
Related PR concourse/houdini#2
Release Note