8529/fix chrome login #9051
Merged
8529/fix chrome login #9051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves a warning message in Chrome related to how it expects CORS to work with local network resources Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
You can read about this change here: https://developer.chrome.com/blog/private-network-access-preflight/ Signed-off-by: Taylor Silva <dev@taydev.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes #8529
Have fly correctly handle preflight requests from Chromium browsers. Details from Chrome about this change can be read here: https://developer.chrome.com/blog/private-network-access-preflight/
Notes
I also bumped the elm package being used. During investigation I was looking at the frontend code and needed to locally compile. This was my first time doing it on an ARM Mac. The older package couldn't find the ARM release of Elm. Bumping to the latest patch of that package resolved the issue for me.
Release Note
flyusing a Chormium browser