Speed up TSA tests #7336
Merged
Speed up TSA tests #7336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP client used by the TSA uses http.DefaultTransport, which has an IdleConnTimeout of 90s. Some of these tests rely on this timeout being hit, meaning that there's a minimum time of 90s for these tests. This resulted in the tsa suite being the slowest to complete, typically taking ~5m. This commit compiles the tsa binary with an overridden IdleConnTimeout of 5s in tests. This does not affect the behaviour of Concourse, as the default behaviour is left unchanged. Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
99b497e to
85e74bd
Compare
taylorsilva
approved these changes
Jul 29, 2021
aoldershaw
added a commit
that referenced
this pull request
Aug 10, 2021
#7336 sped up the TSA tests by compiling the test binary with a package constant set. however, this package was moved, so we weren't setting the constant properly. unfortunately, this doesn't result in a compilation error, and fails silently Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
aoldershaw
added a commit
that referenced
this pull request
Aug 16, 2021
#7336 sped up the TSA tests by compiling the test binary with a package constant set. however, this package was moved, so we weren't setting the constant properly. unfortunately, this doesn't result in a compilation error, and fails silently Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
aoldershaw
added a commit
that referenced
this pull request
Aug 16, 2021
#7336 sped up the TSA tests by compiling the test binary with a package constant set. however, this package was moved, so we weren't setting the constant properly. unfortunately, this doesn't result in a compilation error, and fails silently Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
The HTTP client used by the TSA uses http.DefaultTransport, which has an
IdleConnTimeout of 90s. Some of these tests rely on this timeout being
hit, meaning that there's a minimum time of 90s for these tests. This
resulted in the tsa suite being the slowest to complete, typically
taking ~5m.
This commit compiles the tsa binary with an overridden IdleConnTimeout
of 5s in tests. This does not affect the behaviour of Concourse, as the
default behaviour is left unchanged when compiled normally.
In practice, it looks like this shaves off ~4 minutes from each run of
unitIdleConnTimeoutin tests