Skip to content

Add Protobuf protoc 3.9.1 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Add Protobuf protoc 3.9.1 #65

wants to merge 14 commits into from

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Sep 20, 2019 •
edited
Loading

Specify library name and version: protoc/3.9.1

This is the second part of Google Protobuf. It requires #64 first!

Also, Protoc provides CMake with specific macros, which can't be exported by Conan, so this package requires an exception in the whitelist.

I've added the path to builddirs as required by KB-H019.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@uilianries
Add Protobuf protoc 3.9.1
25b16b2 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Remove metadata from protoc
375cc84 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Contributor

protoc/3.9.1:

  • Error processing recipe: Linux x86_64, Release, gcc 5, libstdc++
    You are depending on 'protobuf/3.9.1' but it is not in the repository

@uilianries uilianries closed this Sep 23, 2019
@uilianries uilianries reopened this Sep 23, 2019
@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
      • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@uilianries
Fix builddirs
176b61a 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

We need to put protoc in the whitelist, since the macros are declared in protoc-config.cmake

@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
      • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@lasote
Copy link
Contributor

lasote commented Sep 24, 2019

We need to put protoc in the whitelist, since the macros are declared in protoc-config.cmake

No, that cannot be whitelisted. We need a mechanism to declare macros to be inherited: conan-io/conan#5798

@uilianries uilianries mentioned this pull request Sep 30, 2019
Closed
@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
      • [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@uilianries
Copy link
Member Author

Could we add a new tag for this PR, like blocked ?

@danimtb
Copy link
Member

danimtb commented Oct 22, 2019

Yeah, it is reasonable

@danimtb danimtb added the blocked Affected by an external issue and waiting until it is solved label Oct 22, 2019
@Croydon Croydon mentioned this pull request Oct 26, 2019
Closed
@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [META LINES (KB-H025)] PEP 263 (encoding) is not allowed in the conanfile. Remove the line 1 (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H025)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@uilianries
Add build modules for Protoc
0b0d47f 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Adjust Protobuf target name
3042fc0 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries requested a review from danimtb November 4, 2019 19:26
@uilianries uilianries mentioned this pull request Nov 4, 2019
Merged
4 tasks
@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' have failed:

Croydon
Croydon reviewed Nov 4, 2019
View reviewed changes
@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' have failed:

@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' have failed:

@uilianries uilianries closed this Nov 7, 2019
@uilianries uilianries reopened this Nov 7, 2019
@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' failed in build 12 (d9dc4373825610f2c3b3592f66eabac6d1cc7259):

@Croydon Croydon mentioned this pull request Feb 13, 2020
Closed
@theirix theirix mentioned this pull request Feb 23, 2020
Closed
12 tasks
@conan-center-bot
Copy link
Contributor

An unexpected error happened and has been reported. Help is on its way! 🏇

@madebr madebr mentioned this pull request Mar 6, 2020
Merged
@madebr
Copy link
Contributor

madebr commented Mar 7, 2020

@uilianries Check uilianries#1

@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' failed in build 14 (92058e26db2cfa8d591823d40acaa9e75cb130cf):

madebr
madebr reviewed Mar 12, 2020
View reviewed changes
@uilianries @madebr
Add c++11 for protoc test_package
d700f58 
Co-Authored-By: Anonymous Maarten <madebr@users.noreply.github.com>
@conan-center-bot
Copy link
Contributor

Some configurations of 'protoc/3.9.1' failed in build 15 (d700f580320adf0550e572f1dce19e1288b443e9):

@madebr
Copy link
Contributor

madebr commented Mar 12, 2020

@uilianries
Do you have an idea?

CMake Error at conanbuildinfo.cmake:461 (message):
  Detected a mismatch for the compiler version between your conan profile
  settings and CMake:

  Compiler version specified in your conan profile: 14

  Compiler version detected in CMake: 19.24

  Please check your conan profile settings (conan profile show

@Croydon
Copy link
Contributor

Croydon commented Mar 19, 2020

Coming from #1136

we might want to add the protoc binaries directly to the protobuf package now

@uilianries
Copy link
Member Author

@Croydon thanks for pinging!

@madebr
Copy link
Contributor

madebr commented Mar 24, 2020 •
edited
Loading

FYI.
I'm working on it atm.
I need it for a recipe.

#1179

@madebr madebr mentioned this pull request Mar 24, 2020
Merged
4 tasks
@madebr
Copy link
Contributor

madebr commented Mar 25, 2020

Looking at the release page of protobuf, they release protobuf and protoc binaries seperately.
See https://github.com/protocolbuffers/protobuf/releases

@uilianries
Copy link
Member Author

I gonna clone this PR since we are moving to a new approach

@uilianries uilianries closed this Mar 25, 2020
@ericriff ericriff mentioned this pull request May 18, 2020
Closed
@0x8000-0000
Copy link
Contributor

@uilianries - can you put here a link to the new approach so we can follow at home :)?

Thanks!

@uilianries
Copy link
Member Author

@0x8000-0000 #1179

artem-kamyshev pushed a commit to artem-kamyshev/conan-center-index that referenced this pull request Sep 28, 2020
@worldemar
Add opencv CI (conan-io#65)
3350a02
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Sep 13, 2023
@datalogics-saharay
Merge pull request conan-io#65 from kam/fix-dl-swig-4
162fc7d 
Fix build of DL SWIG 4.0.2+dl.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb Awaiting requested review from danimtb

2 more reviewers

@Croydon Croydon Croydon left review comments

@madebr madebr madebr left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@lasote lasote

Labels
blocked Affected by an external issue and waiting until it is solved Failed Unexpected Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@uilianries @conan-center-bot @lasote @danimtb @Croydon @madebr @0x8000-0000