Skip to content

poselib: add v2.0.4 #24830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2024
Merged

poselib: add v2.0.4 #24830

merged 4 commits into from
Aug 6, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 5, 2024

Summary

Changes to recipe: poselib/2.0.4

Motivation

https://github.com/PoseLib/PoseLib/releases/tag/v2.0.4
PoseLib/PoseLib@v2.0.3...v2.0.4

Details

/cc @pablospe

@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will approve tomorrow after I check something with the team regarding -march=native and friends, but othwerwise this looks good :)

@AbrilRBS AbrilRBS self-assigned this Aug 5, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
pablospe
pablospe reviewed Aug 5, 2024
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries mentioned this pull request Aug 6, 2024
Closed
3 tasks
uilianries
uilianries reviewed Aug 6, 2024
View reviewed changes
uilianries
uilianries previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No breaking changes PoseLib/PoseLib@v2.0.3...v2.0.4#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

AbrilRBS
AbrilRBS previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valgur
Copy link
Contributor Author

valgur commented Aug 6, 2024

@uilianries Can you comment on the reasoning for the keeping -march=native in v2.0.3? Don't we want avoid using it on CCI?

@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Aug 6, 2024
Open
Closed
uilianries
uilianries reviewed Aug 6, 2024
View reviewed changes
@uilianries uilianries dismissed stale reviews from AbrilRBS and themself via 6874185 August 6, 2024 08:26
@uilianries
Copy link
Member

@uilianries Can you comment on the reasoning for the keeping -march=native in v2.0.3? Don't we want avoid using it on CCI?

My mistake! Sorry!

@conan-center-bot
Copy link
Contributor

Conan v1 pipeline ✔️

All green in build 5 (6874185b16343703212af7901e94cf215f59d374):

  • poselib/2.0.4:
    All packages built successfully! (All logs)

  • poselib/2.0.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (6874185b16343703212af7901e94cf215f59d374):

  • poselib/2.0.4:
    All packages built successfully! (All logs)

  • poselib/2.0.3:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 59c8f4f into conan-io:master Aug 6, 2024
16 checks passed
uilianries added a commit to uilianries/conan-center-index that referenced this pull request Aug 7, 2024
@valgur @uilianries
(conan-io#24830) poselib: add v2.0.4
dddab2b 
* poselib: add v2.0.4

* poselib: tweak patches

* Do not replace march=native

* Follow patch from 2.0.3

---------

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

+2 more reviewers

@pablospe pablospe pablospe left review comments

@vlarsson vlarsson vlarsson left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valgur @conan-center-bot @uilianries @pablospe @AbrilRBS @vlarsson