ninja: conan v2 support & drop 1.9.0 #12918
Conversation
95089d5 to
7ca2693
Compare
* conan v2 support * drop 1.9.0
| self.cpp_info.includedirs = [] | ||
| self.cpp_info.libdirs = [] | ||
| self.cpp_info.resdirs = [] | ||
| self.conf_info.define("tools.cmake.cmaketoolchain:generator", "Ninja") |
There was a problem hiding this comment.
@uilianries @SSE4 @prince-chrismc I believe now that the conan v1 logic CONAN_CMAKE_GENERATOR in this recipe shouldn't have been ported to conan v2. It's not the responsibility of ninja recipe to decide whether CMake generator (or Meson backend) should be Ninja, even if it's in tool_requires.
If there was a tools.ninja:path conf in conan, yes for sure ninja recipe should override it, but changing the behavior of another tool is too much.
There was a problem hiding this comment.
that's a user's personal preference.
There was a problem hiding this comment.
agree, so it should be removed
There was a problem hiding this comment.
Why else would you add it as a requirement? They choose to add it 99% would be to use it... 🤔
Leave it uless it becomes a problem.
It need more complaints
There was a problem hiding this comment.
you may add it e.g. for some meson dependency. but if it suddenly influences on your CMake project by silently changing the generator, it may become a problem. for instance, if library output name depends on generator.
if you add both ninja and make as build requirements in your profile, they will start fighting for the CMake generator.
if it's a personal preference by design, it shouldn't be silently activated from a random dependency in your graph.
…develop * 'master' of github.com:conan-io/conan-center-index: (801 commits) (conan-io#12310) Update qxmpp to use Qt 6.2.4 (conan-io#12960) [bot] Add Access Request users (2022-09-15) (conan-io#12959) [linter] Convert import ConanFile from conans into an error (conan-io#12816) Add bandit (conan-io#12922) gemmlowp: conan v2 support (conan-io#12725) update drogon to 1.8.0 (conan-io#12910) bump dependencies of vulkan-validationlayers; partial conan v2 upgrade (conan-io#12920) wslay: conan v2 support (conan-io#12945) [docs] Hotfix replace wrong cmake method in docs (conan-io#12940) cpp-httplib: add version 0.11.2 (conan-io#12937) [flatbuffers] Add 2.0.6 (conan-io#12936) [xnnpack] Add cci.20220801 (conan-io#12934) docs: 2.0 migration guidance for subfolders (conan-io#12932) aws-c-cal: add 0.5.19 + conan v2 support + improve build on Apple (conan-io#12927) aws-checksums: conan v2 support (conan-io#12926) aws-c-compression: conan v2 support (conan-io#12925) add parson/1.4.0 (conan-io#12921) fast-cdr: conan v2 support (conan-io#12918) ninja: conan v2 support & drop 1.9.0 (conan-io#12917) voropp: conan v2 support + fix download of source code ... Conflicts: recipes/cmake/3.x.x/conanfile.py recipes/doxygen/all/conanfile.py
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!