Skip to content

libxft 2.3.4 #10900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 26, 2022
Merged

libxft 2.3.4 #10900

merged 11 commits into from
May 26, 2022

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented May 23, 2022 •
edited
Loading

Specify library name and version: libxft/2.3.4

#10709
#6880

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier ericLemanissier marked this pull request as ready for review May 23, 2022 14:18
This was referenced May 23, 2022
Closed
Merged
Merged
Merged
toge
toge previously approved these changes May 23, 2022
View reviewed changes
@paulharris
Copy link
Contributor

Ok I'll continue checking, but that should be all.

So we should merge all of these at the same time:
#10900 (this one - libxft)
#10902 (remove xft from xorg - will break packages, which are fixed below)
#10903 (switch pango to libxft)
#10904 (bump imagemagick's dep on pango, and remove its xft workaround)

That is all that I could find that referred explicitly to xorg::xft,
there will be others that depended on xorg::xorg - would they have got the xft includes too?
Not sure what else needs to be checked.

@github-actions github-actions bot mentioned this pull request May 23, 2022
Open
uilianries
uilianries reviewed May 24, 2022
View reviewed changes
@ericLemanissier @uilianries
Apply suggestions from code review
91071e0 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries reviewed May 24, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, it uses the package name's as target, but maybe should be changed to xft

@ericLemanissier @uilianries
Apply suggestions from code review
1038f9a 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Contributor

All green in build 9 (1038f9a0f830f0990d915b15fa775265be04ab69):

  • libxft/2.3.4@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 33fcb51 into conan-io:master May 26, 2022
@ericLemanissier ericLemanissier deleted the patch-11 branch May 26, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

+2 more reviewers

@SSE4 SSE4 SSE4 approved these changes

@toge toge toge left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ericLemanissier @conan-center-bot @paulharris @toge @SSE4 @uilianries