port ZBar recipe to conan2 #16569

jdoubleu · 2023-03-15T11:16:38Z

Specify library name and version: zbar/0.23.92

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2023-03-15T11:16:43Z

All committers have signed the CLA.

prince-chrismc · 2023-03-24T05:23:48Z

Make sure to comment in #4 for access

Also this is missing the test_v1_package which you can find in the docs :)

prince-chrismc

Clean imports (linter comments)

recipes/zbar/all/conanfile.py

prince-chrismc

Overall this looks really good,

Two small things

the builder dont need to be cached anymore
there should be a test_v1_package

jdoubleu · 2023-03-26T18:08:42Z

Thanks for the help!

I'm not that familiar with Conan. I tried to fix it so that it just works™ with v2, which it did. I'm sure there's room for improvements. I appreciate any help!

there should be a test_v1_package

Is the new file backwards compatible? Can it run with both Conan v1 and v2 simultaneously?

prince-chrismc · 2023-03-27T20:55:48Z

It's specifically talored to ConanCenter's build infrastructure and wont be run by default with conan create :)

It only works with Conan 1.x but needs to be manully run (see the docs "developing locally" if you want more details)

prince-chrismc · 2023-03-27T20:56:02Z

Also you need to comment in #4 for access

prince-chrismc · 2023-03-31T21:00:48Z

Make sure to comment in #4

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries · 2023-05-09T15:10:52Z

@jdoubleu Thank you for your contribution, please, consider my PR jdoubleu#1 that contains some important improvements.

Improve conan-io#16569

jdoubleu · 2023-05-09T17:52:33Z

Thanks! Does it address all the previous comments in this PR?
Sorry, I haven't had time to fix it myself.

uilianries · 2023-05-10T08:38:34Z

Thanks! Does it address all the previous comments in this PR?

Yes, all them 😄

Autotools is not happy with Clang 😤

I'll take a look this afternoon.

recipes/zbar/all/conanfile.py

The configure file is already generated.

recipes/zbar/all/conanfile.py

github-actions · 2023-05-10T16:53:03Z

Hooks produced the following warnings for commit dce2f4b

zbar/0.10

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libzbar.dylib, libzbar.0.dylib

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries · 2023-05-11T11:06:19Z

@jdoubleu Hello, please, consider the new PR jdoubleu#2. The versions 0.10 and 0.23 are basically different in terms of building script, so need to patch the 0.10 to be compatible with Mac M1.

[zbar] Apply patch to allow cross building on Mac

jdoubleu · 2023-05-11T15:55:37Z

I've merge the PR and added you as contributor to my fork. You should be able to directly push to the branch, now.

github-actions · 2023-05-11T16:56:48Z

Hooks produced the following warnings for commit 3c94d28

zbar/0.10

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libzbar.dylib, libzbar.0.dylib

Signed-off-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2023-05-12T07:50:58Z

Conan v1 pipeline ✔️

All green in build 11 (ebee417e251aaba61113d6874a056dada6aef53f):

zbar/0.23.92@:
All packages built successfully! (All logs)
zbar/0.10@:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 10 (ebee417e251aaba61113d6874a056dada6aef53f):

zbar/0.10@:
All packages built successfully! (All logs)
zbar/0.23.92@:
All packages built successfully! (All logs)

uilianries · 2023-05-12T08:38:35Z

@jdoubleu Finally is working! 🔥

* port ZBar recipe to conan2 * Apply suggestions from code review * Use rm safe * improve test package Signed-off-by: Uilian Ries <uilianries@gmail.com> * do not run autoreconf The configure file is already generated. * Use autoreconf for 0.23 * patch aarch Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix mac build Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix apple shared install Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Chris Mc <christopherm@jfrog.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

port ZBar recipe to conan2

9bf8af1

conan-center-bot added the User-approval pending label Mar 15, 2023

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Mar 15, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc reviewed Mar 26, 2023

View reviewed changes

recipes/zbar/all/conanfile.py Outdated Show resolved Hide resolved

recipes/zbar/all/conanfile.py Outdated Show resolved Hide resolved

recipes/zbar/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc and others added 2 commits March 26, 2023 09:05

Apply suggestions from code review

3edc4a9

Use rm safe

89ade7e

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Mar 26, 2023

View reviewed changes

recipes/zbar/all/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Mar 26, 2023

View reviewed changes

jdoubleu mentioned this pull request Mar 31, 2023

[!!] Access request #4

Closed

prince-chrismc mentioned this pull request Apr 3, 2023

[bot] Update authorized users list (2023-04-03) #16867

Merged

conan-center-bot added Failed and removed User-approval pending labels Apr 6, 2023

This comment has been minimized.

Sign in to view

prince-chrismc closed this May 4, 2023

prince-chrismc reopened this May 4, 2023

improve test package

3296490

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Merge pull request #1 from uilianries/port-zbar-conan2

f8088d0

Improve conan-io#16569

This comment has been minimized.

Sign in to view

uilianries self-assigned this May 10, 2023

uilianries reviewed May 10, 2023

View reviewed changes

recipes/zbar/all/conanfile.py Outdated Show resolved Hide resolved

do not run autoreconf

d0b6804

The configure file is already generated.

uilianries reviewed May 10, 2023

View reviewed changes

recipes/zbar/all/conanfile.py Show resolved Hide resolved

Use autoreconf for 0.23

dce2f4b

This comment has been minimized.

Sign in to view

patch aarch

2a8267b

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Merge pull request #2 from uilianries/port-zbar-conan2

3c94d28

[zbar] Apply patch to allow cross building on Mac

This comment has been minimized.

Sign in to view

uilianries added 2 commits May 12, 2023 08:51

fix mac build

e61ef4d

Signed-off-by: Uilian Ries <uilianries@gmail.com>

fix apple shared install

ebee417

Signed-off-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot added Unexpected Error and removed Failed labels May 12, 2023

This comment has been minimized.

Sign in to view

uilianries approved these changes May 12, 2023

View reviewed changes

uilianries removed the Unexpected Error label May 12, 2023

SSE4 approved these changes May 13, 2023

View reviewed changes

conan-center-bot merged commit 779ed64 into conan-io:master May 13, 2023

SpaceIm mentioned this pull request May 14, 2023

zbar: bump dependencies + few fixes following v2 migration #17561

Merged

3 tasks

jdoubleu deleted the port-zbar-conan2 branch January 21, 2024 09:02

port ZBar recipe to conan2 #16569

port ZBar recipe to conan2 #16569

Uh oh!

Conversation

jdoubleu commented Mar 15, 2023

Uh oh!

CLAassistant commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

prince-chrismc commented Mar 24, 2023

Uh oh!

prince-chrismc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

Uh oh!

jdoubleu commented Mar 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prince-chrismc commented Mar 27, 2023

Uh oh!

prince-chrismc commented Mar 27, 2023

Uh oh!

prince-chrismc commented Mar 31, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

uilianries commented May 9, 2023

Uh oh!

jdoubleu commented May 9, 2023

Uh oh!

This comment has been minimized.

uilianries commented May 10, 2023

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions bot commented May 10, 2023

Uh oh!

uilianries commented May 11, 2023

Uh oh!

jdoubleu commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

github-actions bot commented May 11, 2023

Uh oh!

This comment has been minimized.

conan-center-bot commented May 12, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

Uh oh!

uilianries commented May 12, 2023

Uh oh!

Uh oh!

CLAassistant commented Mar 15, 2023 •

edited

Loading

jdoubleu commented Mar 26, 2023 •

edited

Loading

jdoubleu commented May 11, 2023 •

edited

Loading