Fixing possible NPE in PubkeyListActivity #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PubkeyListActivity lifecycle and the ServiceConnection lifecycle are independent. In the case that the
onCreateContextMenu
callback fires before theonServiceConnected callback
, thebound
field will be null in onCreateContextMenu (as well as in some of its callees and in the callbacks that it registers) and can throw an exception when dereferenced. This pull request fixes the issue by including a check thatbound
is non-null when computing theloaded
boolean that guards the potentially failing dereferences ofbound
.