Fix: Handle invalid filenames during workflow save (#9434) #9445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vander-Bilt
pushed a commit
to Vander-Bilt/ComfyUI
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9434
Problem Summary
Currently, when a user tries to save a workflow using a filename that contains characters forbidden by the operating system (e.g., a colon : on Windows), the save operation fails silently. The UI provides no warning or error message, leading the user to believe the workflow was saved successfully. This can result in the unintentional loss of work when the user later tries to load the non-existent file.
Solution
This PR addresses the issue by adding error handling to the backend post_userdata endpoint.
This ensures that the frontend receives a specific error it can display to the user, immediately notifying them of the problem so they can correct the filename and save their work successfully.
Screenshot
