Skip to content

Conversation

bigcat88
Copy link
Contributor

According to the documentation of asyncio.run - it does not use the current event loop at all.
Starting from the Python 3.12 we can pass the desired event loop as loop_factory argument, but if we do not pass it, by default the asyncio.run always create a new event_loop

Copy link
Collaborator

@guill guill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think the creation of this additional loop was a result of a misunderstanding by me. Based on the documentation linked by @bigcat88, this code should essentially have been a noop.

@guill guill added Good PR This PR looks good to go, it needs comfy's final review. Run-CI-Test This is an administrative label to tell the CI to run full automatic testing on this PR now. labels Aug 11, 2025
Copy link

(Automated Bot Message) CI Tests are running, you can view the results at https://ci.comfy.org/?branch=9284%2Fmerge

@comfyanonymous comfyanonymous merged commit fa340ad into comfyanonymous:master Aug 11, 2025
13 of 21 checks passed
Thor-ATX pushed a commit to asteriafilmco/ComfyUI that referenced this pull request Aug 11, 2025
…ams-update

* commit 'f4231a80b1b904b45ade0def9b37320c4adfe71b':
  fix(Kling Image API Node): do not pass "image_type" when no image (comfyanonymous#9271)
  Support SimpleTuner lycoris lora for Qwen-Image (comfyanonymous#9280)
  Update template & embedded docs (comfyanonymous#9283)
  remove creation of non-used asyncio_loop (comfyanonymous#9284)
  Only show feature flags log when verbose. (comfyanonymous#9281)
  Bump pytorch cuda and rocm versions in readme instructions. (comfyanonymous#9273)
  Not sure if AMD actually support fp16 acc but it doesn't crash. (comfyanonymous#9258)
  Users report gfx1201 is buggy on flux with pytorch attention. (comfyanonymous#9244)
  async API nodes  (comfyanonymous#9129)
  _ui.py import torchaudio safety check (comfyanonymous#9234)
  Fix RepeatLatentBatch not working on multi dim latents. (comfyanonymous#9227)
  Update frontend to v1.24.3 (comfyanonymous#9175)
  Update template to 0.1.52 (comfyanonymous#9206)
  Fixed an issue where qwenLora could not be loaded properly. (comfyanonymous#9208)
Vander-Bilt pushed a commit to Vander-Bilt/ComfyUI that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good PR This PR looks good to go, it needs comfy's final review. Run-CI-Test This is an administrative label to tell the CI to run full automatic testing on this PR now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants