Skip to content

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Jul 27, 2025

Enable & update Moonvalley V2V node to comply with API specification requirements and validate on client before sending request, preventing users from wasting API calls.

Changes

  • Resolution validation: Enforce exact supported resolutions (1920x1080, 1080x1920, 1152x1152, 1536x1152, 1152x1536)
  • Frame validation: Update from divisible by 32 to divisible by 16
  • Format validation: Add MP4 container format requirement
  • Parameter cleanup: Remove steps and guidance_scale from V2V inference params (better to let server choose best default per model providers)
  • Duration handling: Enforce 5-second video length with auto-trimming
  • API enhancement: Add get_container_format() method to VideoInput classes for format detection

Testing

Tested with various video inputs to ensure:

  • Non-MP4 formats are rejected with clear error message
  • Unsupported resolutions are rejected with list of valid options
  • Videos longer than 5s are automatically trimmed
  • Videos shorter than 5s show appropriate error
  • Motion intensity parameter only applies to Motion Transfer control type
Selection_1798 Selection_1799 Selection_1800 Selection_1801

- Add exact resolution validation for supported resolutions (1920x1080, 1080x1920, 1152x1152, 1536x1152, 1152x1536)
- Change frame count validation from divisible by 32 to 16
- Add MP4 container format validation
- Remove internal parameters (steps, guidance_scale) from V2V inference params
- Update video duration handling to support only 5 seconds (auto-trim if longer)
- Add motion_intensity parameter (0-100) for Motion Transfer control type
- Add get_container_format() method to VideoInput classes
@christian-byrne christian-byrne force-pushed the moonvalley-v2v-spec-compliance branch from 29c9b4f to d90b965 Compare July 27, 2025 05:20
@christian-byrne christian-byrne force-pushed the moonvalley-v2v-spec-compliance branch from d90b965 to 5a92db3 Compare July 27, 2025 05:40
@comfyanonymous comfyanonymous merged commit e6d9f62 into comfyanonymous:master Jul 27, 2025
6 checks passed
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Jul 29, 2025
…nymous#9069)

* [moonvalley] Update V2V node to match API specification

- Add exact resolution validation for supported resolutions (1920x1080, 1080x1920, 1152x1152, 1536x1152, 1152x1536)
- Change frame count validation from divisible by 32 to 16
- Add MP4 container format validation
- Remove internal parameters (steps, guidance_scale) from V2V inference params
- Update video duration handling to support only 5 seconds (auto-trim if longer)
- Add motion_intensity parameter (0-100) for Motion Transfer control type
- Add get_container_format() method to VideoInput classes

* update negative prompt
Vander-Bilt pushed a commit to Vander-Bilt/ComfyUI that referenced this pull request Aug 26, 2025
…nymous#9069)

* [moonvalley] Update V2V node to match API specification

- Add exact resolution validation for supported resolutions (1920x1080, 1080x1920, 1152x1152, 1536x1152, 1152x1536)
- Change frame count validation from divisible by 32 to 16
- Add MP4 container format validation
- Remove internal parameters (steps, guidance_scale) from V2V inference params
- Update video duration handling to support only 5 seconds (auto-trim if longer)
- Add motion_intensity parameter (0-100) for Motion Transfer control type
- Add get_container_format() method to VideoInput classes

* update negative prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants