Skip to content

Conversation

Thor-ATX
Copy link
Contributor

No description provided.

@Thor-ATX Thor-ATX requested a review from comfyanonymous as a code owner July 25, 2025 03:02
Copy link
Collaborator

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The only non-formatting change from this PR is changing the default value for the negative_prompt in all the nodes from

  • Old negative prompt: Focused on video/camera artifacts (gopro, vignette, scanlines, 360 camera, VR, etc.)
  • New negative prompt: Focused on 3D/game artifacts (low-poly, flat shader, bad rigging, stiff animation, etc.)

@comfyanonymous comfyanonymous merged commit c60467a into comfyanonymous:master Jul 25, 2025
5 of 6 checks passed
@GlamoramaAttack
Copy link

GlamoramaAttack commented Jul 26, 2025

ComfyUI Version: v0.3.45-22-g0621d73a | Released on '2025-07-26'
Torch version: 2.7.1+cu128
Python version: 3.12.9 (
ComfyUI version: 0.3.45
ComfyUI frontend version: 1.23.4

Since this commit for comfy_api_nodes I have this error message:

[Prompt Server] web root: D:\ComfyUI\venv\Lib\site-packages\comfyui_frontend_package\static
Traceback (most recent call last):
  File "D:\ComfyUI\nodes.py", line 2124, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 999, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "D:\ComfyUI\comfy_api_nodes\canary.py", line 5, in <module>
    raise Exception("INSTALL NEW VERSION OF PYAV TO USE API NODES.")

A reinstall of av doesn't change it. Prior I git pulled a few days ago and had no error messages. Even though I see now for comfy_api that #8830 is an unresolved issue? But for some reason I didn't have an error message about it. I don't use API but that's the full text:

WARNING: some comfy_api_nodes/ nodes did not import correctly. This may be because they are missing some dependencies.

IMPORT FAILED: nodes_ideogram.py
IMPORT FAILED: nodes_openai.py
IMPORT FAILED: nodes_minimax.py
IMPORT FAILED: nodes_veo2.py
IMPORT FAILED: nodes_kling.py
IMPORT FAILED: nodes_bfl.py
IMPORT FAILED: nodes_luma.py
IMPORT FAILED: nodes_recraft.py
IMPORT FAILED: nodes_pixverse.py
IMPORT FAILED: nodes_stability.py
IMPORT FAILED: nodes_pika.py
IMPORT FAILED: nodes_runway.py
IMPORT FAILED: nodes_tripo.py
IMPORT FAILED: nodes_moonvalley.py
IMPORT FAILED: nodes_rodin.py
IMPORT FAILED: nodes_gemini.py

This issue might be caused by new missing dependencies added the last time you updated ComfyUI.
Please run the update script: update/update_comfyui.bat

@GlamoramaAttack
Copy link

I have now replaced av-12.3.0 with av-14.4.0 and the error message disappeared.

@christian-byrne
Copy link
Collaborator

That is expected, we are using an av feature only available on versions >=14.2.0 as specified in the requirements.txt of the repo

rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Jul 29, 2025
Co-authored-by: thorsten <thorsten@tripod-digital.co.nz>
Vander-Bilt pushed a commit to Vander-Bilt/ComfyUI that referenced this pull request Aug 26, 2025
Co-authored-by: thorsten <thorsten@tripod-digital.co.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants