Replace torchaudio.load with pyav. #8989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigcat88
reviewed
Jul 21, 2025
| sample_offset = int(sr * seek_time) | ||
| num_samples = int(sr * duration) if duration >= 0 else -1 | ||
|
|
||
| # Small negative offset for MP3 artifacts, NOTE: this is LLM code so idk if it's actually necessary' |
There was a problem hiding this comment.
it will be more accurate to just skip one sample than to skip 0.1 second(but 0.1 will be enough for most of mp3, but will not cover all cases)
this is link to Chromium sources(FFmpegDemuxer::SeekInternal):
https://chromium.googlesource.com/chromium/src/media/%2B/master/filters/ffmpeg_demuxer.cc
SurpassHR
pushed a commit
to SurpassHR/ComfyUI-Playground
that referenced
this pull request
Jul 24, 2025
bigcat88
added a commit
to bigcat88/ComfyUI
that referenced
this pull request
Jul 25, 2025
rakki194
pushed a commit
to rakki194/ComfyUI
that referenced
this pull request
Jul 29, 2025
Vander-Bilt
pushed a commit
to Vander-Bilt/ComfyUI
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.