Skip to content

Fix MaskComposite error when destination has 2 dimensions #8915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Fix MaskComposite error when destination has 2 dimensions #8915

merged 1 commit into from
Jul 16, 2025

Conversation

bman654
Copy link
Contributor

@bman654 bman654 commented Jul 15, 2025

Fix code that is using the original destination input instead of the reshaped value.

If destination has 2 dimensions, then MaskComposite will throw

22:43:41.657 [Warning] [ComfyUI-0/STDERR]   File "G:\Apps\SwarmUI\dlbackend\comfy\ComfyUI\comfy_extras\nodes_mask.py", line 250, in combine
22:43:41.657 [Warning] [ComfyUI-0/STDERR]     destination_portion = destination[:, top:bottom, left:right]
22:43:41.658 [Warning] [ComfyUI-0/STDERR]                           ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
22:43:41.659 [Warning] [ComfyUI-0/STDERR] IndexError: too many indices for tensor of dimension 2
22:43:41.660 [Warning] [ComfyUI-0/STDERR]

because, even though it reshapes the input, it accidentally uses the original input when computing the destination_portion to be affected by the operation.

@bman654
Fix MaskComposite error when destination has 2 dimensions
edf7eb8 
Fix code that is using the original `destination` input instead of the reshaped value.
@bman654 bman654 mentioned this pull request Jul 15, 2025
Merged
@comfyanonymous comfyanonymous merged commit 6b8062f into comfyanonymous:master Jul 16, 2025
5 checks passed
@bman654 bman654 deleted the composite-mask-fix branch July 16, 2025 13:10
@bigcat88 bigcat88 mentioned this pull request Jul 16, 2025
Merged
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Jul 21, 2025
@bman654 @rakki194
Fix MaskComposite error when destination has 2 dimensions (comfyanony…
3c0ec79 
…mous#8915)

Fix code that is using the original `destination` input instead of the reshaped value.
Vander-Bilt pushed a commit to Vander-Bilt/ComfyUI that referenced this pull request Aug 26, 2025
@bman654
Fix MaskComposite error when destination has 2 dimensions (comfyanony…
72506b9 
…mous#8915)

Fix code that is using the original `destination` input instead of the reshaped value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoland68 yoland68 Awaiting requested review from yoland68 yoland68 is a code owner

@robinjhuang robinjhuang Awaiting requested review from robinjhuang robinjhuang is a code owner

@pythongosssss pythongosssss Awaiting requested review from pythongosssss pythongosssss is a code owner

@ltdrdata ltdrdata Awaiting requested review from ltdrdata ltdrdata is a code owner

@Kosinkadink Kosinkadink Awaiting requested review from Kosinkadink Kosinkadink is a code owner

@webfiltered webfiltered Awaiting requested review from webfiltered webfiltered is a code owner

@christian-byrne christian-byrne Awaiting requested review from christian-byrne christian-byrne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bman654 @comfyanonymous