Skip to content

Conversation

lgldlk
Copy link
Contributor

@lgldlk lgldlk commented Jun 19, 2025

“--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes

This PR originates from ComfyUI Bounty Tasks.
It introduces the "--whitelist-custom-nodes" argument for the Comfy core, to be used alongside "--disable-all-custom-nodes" for development purposes. Here's what this feature does:

The "--whitelist-custom-nodes" argument allows specific custom nodes to be enabled in the Comfy core while "--disable-all-custom-nodes" is active, facilitating targeted testing and development of selected custom nodes without enabling all of them.

Below are the tests I conducted after completing the development.

Normal startup:

test: normal use

python main.py

Prestartup
image

custom_node

image
image

Start without plugins:

test: not affect disable-all-custom-nodes node functionality

python main.py --disable-all-custom-nodes

image
image

Specify whitelist-custom-nodes, multiple plugins separated by spaces:

test:Whitelist only one plugin

python main.py --disable-all-custom-nodes --whitelist-custom-nodes  ComfyUI-PSD-Replace

Prestartup
image
custom_node
image
image
As expected, the other plugins were not loaded.

image

test:Whitelist Multiple plugins

python main.py --disable-all-custom-nodes --whitelist-custom-nodes ComfyUI-KJNodes ComfyUI-PSD-Replace

Prestartup
image
custom_nodes
image
image
image

python main.py --disable-all-custom-nodes --whitelist-custom-nodes ComfyUI-KJNodes ComfyUI-PSD-Replace ComfyUI-Manager

Prestartup
image
custom_nodes
image
image

When --whitelist-custom-nodes is specified without plugins:

python main.py --disable-all-custom-nodes --whitelist-custom-nodes

image

…sable-all-custom-nodes” for development purposes
@lgldlk lgldlk requested a review from comfyanonymous as a code owner June 19, 2025 09:45
@jtydhr88
Copy link
Contributor

I think you need to fix source format issue before comfy merged

@lgldlk lgldlk requested a review from guill June 25, 2025 09:23
Copy link
Collaborator

@guill guill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😁

@guill guill added the Good PR This PR looks good to go, it needs comfy's final review. label Jun 26, 2025
@comfyanonymous comfyanonymous merged commit ba9548f into comfyanonymous:master Jun 28, 2025
7 checks passed
Lido95 pushed a commit to Lido95/ComfyUI1 that referenced this pull request Jun 29, 2025
…all-custom-nodes” for development purposes (comfyanonymous#8592)

* feat: “--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes

* feat: Simplify custom nodes whitelist logic to use consistent code paths
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Jul 21, 2025
…all-custom-nodes” for development purposes (comfyanonymous#8592)

* feat: “--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes

* feat: Simplify custom nodes whitelist logic to use consistent code paths
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Jul 29, 2025
…all-custom-nodes” for development purposes (comfyanonymous#8592)

* feat: “--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes

* feat: Simplify custom nodes whitelist logic to use consistent code paths
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Jul 29, 2025
…all-custom-nodes” for development purposes (comfyanonymous#8592)

* feat: “--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes

* feat: Simplify custom nodes whitelist logic to use consistent code paths
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Aug 29, 2025
…all-custom-nodes” for development purposes (comfyanonymous#8592)

* feat: “--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes

* feat: Simplify custom nodes whitelist logic to use consistent code paths
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Aug 29, 2025
…all-custom-nodes” for development purposes (comfyanonymous#8592)

* feat: “--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes

* feat: Simplify custom nodes whitelist logic to use consistent code paths
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Aug 29, 2025
…all-custom-nodes” for development purposes (comfyanonymous#8592)

* feat: “--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes

* feat: Simplify custom nodes whitelist logic to use consistent code paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good PR This PR looks good to go, it needs comfy's final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants