-
Notifications
You must be signed in to change notification settings - Fork 684
Replace tm-db with cometbft-db on main
#137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
main
8ab2565
to
625c509
Compare
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…uilding of database support Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
134034e
to
c0b5511
Compare
consensus/reactor_test.go
Outdated
Round: 1, Index: 1, Type: cmtproto.PrevoteType}, | ||
Message: &cmtcons.HasVote{ | ||
Height: 1, | ||
Round: 1, Index: 1, Type: cmtproto.PrevoteType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor] Might want to separate each field in its own line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird the formatter didn't pick this up. I suspect that eventually switching to something like gofumpt for formatting will help here, but we need to resolve some of our concerns around its use first.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
For me it worked only after i used |
Follow-up to #137. Fixes the Docker builds that were failing to be parsed by GitHub Actions. Also fixes our `make build-docker` target to build images in the same way we do in CI. On Linux, I have to explicitly tell Docker to use BuildKit to pass the target/build platform args in: ```bash DOCKER_BUILDKIT=1 make build-docker ``` Given that I've also proven now that the images do build in CI (see [this workflow](https://github.com/cometbft/cometbft/actions/runs/3964436268/jobs/6793294390) and [this one](https://github.com/cometbft/cometbft/actions/runs/3964436273/jobs/6793294238)), we no longer need to build on every change to every pull request. The E2E node Docker image in particular takes nearly 30mins to build, so that would slow us down tremendously. It's far better to build those images only once PRs get merged. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed
Closes #133.
This needs to temporarily update all of our workflows and Docker image builds to ensure that they can reach the cometbft-db repository. I've logged an issue to keep track of reverting this in #158.
I'm currently manually running our nightly E2E tests on this branch to ensure that this still works: https://github.com/cometbft/cometbft/actions/runs/3952269253
This will have to be manually backported to
v0.37.x
andv0.34.x
.After this change, while the repos are still private, to be able to build the Docker images and run the E2E tests locally you'll need to do the following for each shell in which you're working:
Your GitHub API token must have full access (read/write) to all repositories (i.e. the repo checkbox when configuring permissions). See https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token
I'd recommend setting an expiry of 30 days to any tokens used for this purpose, so we don't accidentally leave them lingering.
PR checklist
CHANGELOG_PENDING.md
updated, or no changelog entry neededdocs/
) and code comments, or nodocumentation updates needed